chore: Add Room database for api v2 by sirambd · Pull Request #231 · Infomaniak/multiplatform-SwissTransfer

sirambd · 2026-02-06T09:15:08Z

Depends on #230

Copilot

Pull request overview

This PR adds Room database support for API v2 to handle authenticated user transfers, while maintaining the existing Realm database for guest users. The implementation introduces new database entities, DAOs, platform-specific configurations, and comprehensive test coverage.

Changes:

Added Room database dependencies (room 2.8.4, ksp plugin, sqlite-bundled, robolectric for testing)
Created Room entities (TransferDB, FileDB) and DAOs (TransferDao, UploadDao) for v2 transfers
Implemented platform-specific DatabaseProvider and DatabaseConfig for Android and Apple platforms
Updated AccountManager to use Room for AuthUser and Realm for GuestUser
Added PENDING_UPLOAD status to TransferStatus enum and changed Transfer interface defaults

Reviewed changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
gradle/libs.versions.toml	Added Room, KSP, SQLite, Robolectric dependencies
build.gradle.kts	Applied KSP and Room plugins at project level
STDatabase/build.gradle.kts	Configured Room schema directory and KSP processors
DatabaseProvider.kt	Core Room database builder with platform abstractions
DatabaseConfig.kt	Platform-specific database configuration class
Converters.kt	Type converters for Set serialization
TransferDB.kt	Room entity for transfers with TransferWithFiles relation
FileDB.kt	Room entity for files with foreign key to TransferDB
TransferDao.kt	DAO with queries for transfer CRUD operations
UploadDao.kt	DAO with queries specific to upload transfers
AccountManager.kt	Updated to handle both Room (AuthUser) and Realm (GuestUser)
SwissTransferInjection.kt	Added DatabaseConfig parameter and appDatabase initialization
Transfer.kt (v2)	Changed transferDirection/transferStatus from nullable to non-nullable
TransferStatus.kt	Added PENDING_UPLOAD status
RobolectricTestsBase.kt	Platform-specific test base class for Android/Robolectric
DatabaseConfigFactory.kt	Platform-specific test database configuration factory
TransfersTest.kt	Comprehensive tests for transfer operations
UploadTest.kt	Tests for upload-specific operations
DummyTransferForV2.kt	Test data for v2 transfers
Database schemas	Generated Room schema JSON files for version 1

Comments suppressed due to low confidence (1)

STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/AccountManager.kt:65

Inconsistent behavior in loadUser for AuthUser. When a GuestUser is loaded, the database is initialized (lines 61-62), but when an AuthUser is loaded with a different id, no database initialization occurs. This asymmetry could lead to issues where AuthUser data isn't properly initialized. Consider adding appropriate database initialization for AuthUser as well.

        mutex.withLock {
            if (currentUser?.id != user.id && user is STUser.GuestUser) {
                appSettingsController.initAppSettings(emailLanguageUtils.getEmailLanguageFromLocal())
                realmProvider.openTransfersDb(user.id)
            }
            currentUser = user
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...kotlin/com/infomaniak/multiplatform_swisstransfer/common/interfaces/transfers/v2/Transfer.kt

...base/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/Converters.kt

...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/dao/UploadDao.kt

...src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/dao/TransferDao.kt

...emas/com.infomaniak.multiplatform_swisstransfer.database.DatabaseProvider.AppDatabase/1.json

...ain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/transfers/v2/FileDB.kt

...base/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/Converters.kt

...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/dao/UploadDao.kt

Copilot · 2026-02-06T09:31:12Z

.../src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/AccountManager.kt

+        if (user is STUser.AuthUser) {
+            appDatabase.getTransferDao().deleteTransfers(user.id)
+        } else {
+            uploadController.removeData()
+            transferController.removeData()
+            realmProvider.closeAllDatabases()
+        }


Missing appSettingsController.removeData() call for AuthUser logout. In the GuestUser logout path (line 77), appSettingsController.removeData() is called, but it's not called for AuthUser. This inconsistency could leave settings data behind when an authenticated user logs out.

LunarX · 2026-02-06T11:50:38Z

...kotlin/com/infomaniak/multiplatform_swisstransfer/common/interfaces/transfers/v2/Transfer.kt

+    val transferDirection: TransferDirection get() = TransferDirection.RECEIVED
+    val transferStatus: TransferStatus get() = TransferStatus.READY


Why do we need default values? Can they not be abstract?

Probably the best solution we have to avoid polluting the TransferApi model with properties that don't exist on the backend (@Ignore wouldn't give us this advantage).

BTW, code using that doesn't exist yet (apart from tests).

We might remove this common interface, to just have 2 separate models connected only by toXxx conversion extension functions.
If/when we do this, it will remove this kind of confusion.

LunarX · 2026-02-06T11:59:05Z

.../src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/AccountManager.kt

+        } else {
+            uploadController.removeData()
+            transferController.removeData()
+            realmProvider.closeAllDatabases()


Will the appSettingsDb be migrated to Room at some point?

Yes, it's coming in a subsequent PR (not opened yet)

LunarX · 2026-02-06T12:33:54Z

...otlin/com/infomaniak/multiplatform_swisstransfer/database/v2/RobolectricTestsBase.android.kt

+import org.robolectric.annotation.Config
+
+@RunWith(RobolectricTestRunner::class)
+@Config(sdk = [35])


Should we not bump this to 36 for KMP?

Let's make a PR to update this, and the project's compileSdk too.
Feel free to do it if you have time before I do.

.../kotlin/com/infomaniak/multiplatform_swisstransfer/database/v2/dataset/DummyTransferForV2.kt

LunarX · 2026-02-06T13:08:10Z

.../kotlin/com/infomaniak/multiplatform_swisstransfer/database/v2/dataset/DummyTransferForV2.kt

+object DummyTransferForV2 {
+    val expired: Transfer
+    val notExpired: Transfer
+
+    val transfer1 = object : Transfer {
+        override val id: String = "transferLinkUUID1"
+        override val senderEmail: String = ""
+        override val title: String = ""
+        override val message: String = ""
+        override val createdAt: Long = 0
+        override val expiresAt: Long = 1_730_458_842L // 01/11/2024
+        override val totalSize: Long = 0
+    }
+
+    val transfer2 = object : Transfer by transfer1 {
+        override val id: String = "transfer2"
+        override var expiresAt: Long = 4_102_441_200L // 01/01/2100
+        override val transferStatus: TransferStatus = TransferStatus.WAIT_VIRUS_CHECK
+    }
+
+    // Transfer with downloadCounterCredit greater than 0.
+    val transfer3 = object : Transfer by transfer1 {
+        override val id: String = "transfer3"
+        override var expiresAt: Long = 4_102_441_200L // 01/01/2100
+        override val transferStatus: TransferStatus = TransferStatus.WAIT_VIRUS_CHECK
+    }
+
+    // Transfer with downloadCounterCredit equal to 0.
+    val transfer4 = object : Transfer by transfer1 {
+        override val id: String = "transfer4"
+        override var expiresAt: Long = 4_102_441_200L // 01/01/2100
+        override val transferStatus: TransferStatus = TransferStatus.WAIT_VIRUS_CHECK
+    }
+
+    init {
+        expired = transfer1
+        notExpired = transfer2
+    }


Have you considered simplifying it something like this?

object DummyTransferForV2 { private fun transferOf( id: String, expiresAt: Long, transferStatus: TransferStatus = TransferStatus.READY, ): Transfer = object : Transfer { override val id: String = id override val senderEmail: String = "" override val title: String? = null override val message: String? = null override val createdAt: Long = 0 override val expiresAt: Long = expiresAt override val totalSize: Long = 0 override val transferStatus: TransferStatus = transferStatus } val transfer1 = transferOf("transferLinkUUID1", 1_730_458_842L) // 01/11/2024 val transfer2 = transferOf("transfer2", 4_102_441_200L, TransferStatus.WAIT_VIRUS_CHECK) // 01/01/2100 val transfer3 = transferOf("transfer3", 4_102_441_200L, TransferStatus.WAIT_VIRUS_CHECK) val transfer4 = transferOf("transfer4", 4_102_441_200L, TransferStatus.WAIT_VIRUS_CHECK) val expired: Transfer = transfer1 val notExpired: Transfer = transfer2

Agreed. Doing it, with some slight improvements.

LunarX · 2026-02-06T15:06:04Z

...rc/commonTest/kotlin/com/infomaniak/multiplatform_swisstransfer/database/v2/TransfersTest.kt

+        val updatedTransfer = TransferDB(
+            id = transfer.id,
+            senderEmail = transfer.senderEmail,
+            title = "Updated Title",
+            message = transfer.message,
+            createdAt = transfer.createdAt,
+            expiresAt = transfer.expiresAt,
+            totalSize = transfer.totalSize,
+            userOwnerId = userId,
+            transferDirection = TransferDirection.SENT,
+            transferStatus = TransferStatus.READY,
+        )


Can't we copy the old instance and only modify the title?

github-actions · 2026-02-18T14:35:07Z

This PR/issue depends on:

~~chore: Handle api v2 calls with api repository for api v2 #230~~
By Dependent Issues (🤖). Happy coding!

github-actions · 2026-02-18T14:35:07Z

This PR/issue depends on:

~~chore: Handle api v2 calls with api repository for api v2 #230~~
By Dependent Issues (🤖). Happy coding!

sonarqubecloud · 2026-02-19T13:11:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions bot assigned sirambd Feb 6, 2026

github-actions bot added the dependent label Feb 6, 2026

sirambd requested a review from Copilot February 6, 2026 09:25

Copilot started reviewing on behalf of sirambd February 6, 2026 09:25 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

sirambd mentioned this pull request Feb 6, 2026

chore: Add new file tree algo for api v2 #232

Open

sirambd force-pushed the v2-3-db branch from edada64 to 63228d9 Compare February 6, 2026 15:10

LunarX requested changes Feb 6, 2026

View reviewed changes

LouisCAD force-pushed the v2-3-db branch from 63228d9 to 1a86ac9 Compare February 11, 2026 09:57

LouisCAD self-assigned this Feb 11, 2026

LouisCAD force-pushed the v2-3-db branch 3 times, most recently from 3bc0bf4 to 6ffe0e1 Compare February 12, 2026 15:56

Base automatically changed from v2-2-api to protected/v2 February 18, 2026 14:34

github-actions bot removed the dependent label Feb 18, 2026

sirambd added 13 commits February 18, 2026 15:38

chore: Implement room database

66ed05e

chore: Add multiplatform DatabaseConfig

8ddb7cc

chore: Add DatabaseProvider

1c2c59c

chore: Add PENDING_UPLOAD in TransferStatus

0b52fb4

chore: Rename getRoomDatabase into getAppDatabase

e77278a

chore: Handle logout with specific user

9d80c31

chore: Inject AppDatabase

2ee3552

chore: Update Transfer interface

0104d52

chore: Improve load and logout user

3fe6da1

chore: Add room entities

20dc7ae

chore: Update room schema

210a6f1

chore: Add utils for multiplatform tests

85048e1

chore: Add room transferDao and UploadDao

a73b917

sirambd and others added 20 commits February 18, 2026 15:38

chore: Update DAYS_SINCE_EXPIRATION visibility to internal

e25d876

chore: Add support for robolectric in DatabaseProvider

a7843fe

chore: Add Dummy transfers for api v2

f14405d

chore: Add secondary constructors

add71db

chore: Add transfer tests

709b884

chore: Add UploadTest

557aabb

chore: Test the case getTransfersExcludesPendingUploads

31444fb

chore: Add missing suspend

6494963

chore: Add missing shared linkId

c9f92b1

chore: Add android libs dependencies for tests

d87a0a5

chore: Replace dao methods by flow when needed

8bc8eec

chore: Add missing thumbnailPath

62464cd

chore: Remove useless relation

f20f475

fix: Fix dependency scope of Room runtime

697514e

chore: Update database schema dump

bbb3e39

chore: Fix parameter name

50c5083

fix: Fix testing issue by making RobolectricTestsBase abstract

95d0070

fix: Fix nullability of DAO functions

9b32759

chore: Make case of SQL queries consistent

757e8bd

perf: Add missing index on column used in foreign key

3c5b547

LouisCAD force-pushed the v2-3-db branch from 6ffe0e1 to 3c5b547 Compare February 18, 2026 14:38

LouisCAD added 2 commits February 19, 2026 09:42

chore: Remove obsolete comments

47c73c3

doc: Update KDoc of AccountManager

c1452c6

		val transferDirection: TransferDirection get() = TransferDirection.RECEIVED
		val transferStatus: TransferStatus get() = TransferStatus.READY

Conversation

sirambd commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

sonarqubecloud bot commented Feb 19, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments