Open
Conversation
|
This PR/issue depends on:
|
sirambd
force-pushed
the
v2-4-file-tree
branch
from
cd1a18a to
d363ca7
Compare
LouisCAD
force-pushed
the
v2-3-db
branch
2 times, most recently
from
da414a0 to
7226764
Compare
LouisCAD
force-pushed
the
v2-4-file-tree
branch
from
d363ca7 to
9c7c603
Compare
LouisCAD
force-pushed
the
v2-4-file-tree
branch
from
9c7c603 to
34e8ee1
Compare
LouisCAD
force-pushed
the
v2-4-file-tree
branch
from
34e8ee1 to
6534d40
Compare
There are the same tests as v1
LouisCAD
force-pushed
the
v2-4-file-tree
branch
from
6534d40 to
4c23e0f
Compare
|
LunarX
requested changes
Feb 19, 2026
Comment on lines
+56
to
+60
| // Skip duplicated separators | ||
| if (nextSlash == currentIndex) { | ||
| currentIndex++ | ||
| continue | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we bother testing for this case. Is this really something useful?
Comment on lines
+52
to
+54
| var currentIndex = 0 | ||
| while (currentIndex < lastSlash) { | ||
| val nextSlash = filePath.indexOf('/', currentIndex).takeIf { it != -1 } ?: lastSlash |
Contributor
There was a problem hiding this comment.
Could currentIndex and nextSlash be renamed into currentSlashIndex and nextSlashIndex to show they are the same things?
| if (lastSlash <= 0) return null // No parent folder (root file) | ||
|
|
||
| var parentId: String? = null | ||
| val pathBuilder = StringBuilder(lastSlash) |
Contributor
There was a problem hiding this comment.
Why do we need to bother carrying a pathBuilder. We could simply substring filePath directly up to "nextSlash"
| mimeType = null, | ||
| isFolder = true, | ||
| transferId = transferId, | ||
| folderId = parentId |
Contributor
There was a problem hiding this comment.
Isn't "parentFolderId" better than "folderId"? Some instances of FileDB represent a folder so having a field "folderId" can be confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #231