Skip to content

feat: Download a transfer with password from api v2 #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirambd merged 2 commits into from
Mar 6, 2026
Merged

feat: Download a transfer with password from api v2 #597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e15a2b
feat: Download a transfer with password from api v2
sirambd Mar 6, 2026
ece9411
fix: Fix API v2 password header addition logic
LunarX Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDownload.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,19 @@ private suspend fun buildDownloadRequest(
val fileName = DownloadManagerUtils.withoutProblematicCharacters(targetFile.fileName)
name = "SwissTransfer/$fileName${if (targetFile.isFolder) ".zip" else ""}"
}
else -> {
transfer.apiSource == TransferUi.ApiSource.V1 -> {
url = apiUrlCreator.downloadFilesUrl(transfer.uuid) ?: return null
val fileName = currentDateTimeWithSecondsString()
name = "SwissTransfer/$fileName.zip"
}
else -> return null
}

val extraHeaders = buildSet {
if (transfer.apiSource == TransferUi.ApiSource.V2) {
val password = transfer.password ?: return@buildSet
add("Transfer-Password" to password)
}
}

return runCatching {
Expand All @@ -255,6 +263,7 @@ private suspend fun buildDownloadRequest(
nameWithoutProblematicChars = name,
mimeType = Dispatchers.IO { FileType.guessMimeTypeFromFileName(name) },
userAgent = userAgent,
extraHeaders = extraHeaders,
)
}.cancellable().onFailure {
// Unlikely to happen since mitigation in requestFor, but we don't want to crash the app if it happens.
Expand Down
Loading