feat: Download a transfer with password from api v2#597
Merged
Conversation
|
This PR/issue depends on:
|
There was a problem hiding this comment.
Pull request overview
Adds support for downloading transfers via API v2 when a password is required, by attaching an HTTP header to the Android DownloadManager request.
Changes:
- Adds
extraHeadersto theDownloadManagerUtils.requestFor(...)call to support passing a transfer password for API v2 downloads. - Restricts “download whole transfer as zip” behavior to API v1 (returns
nullfor other API sources).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDownload.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDownload.kt
Show resolved
Hide resolved
LunarX
requested changes
Mar 6, 2026
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDownload.kt
Show resolved
Hide resolved
tevincent
approved these changes
Mar 6, 2026
sirambd
force-pushed
the
download-with-password
branch
from
0c19638 to
ece9411
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #595