feat(igr-ts): update igr-ts templates#1598
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Ignite UI for React TypeScript (igr-ts) CLI templates to align with newer tooling defaults (Vite/Vitest/TypeScript/ESLint), refresh public assets, and tweak sample components for improved runtime behavior.
Changes:
- Restructures TypeScript configuration into referenced
tsconfig.app.json/tsconfig.node.jsonwith updated compiler options. - Updates template toolchain configuration (Vitest browser provider, ESLint flat config) and dependency versions.
- Adjusts sample/template components (navigation header active state, chart legend wiring) and refreshes favicon/icon assets.
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/templates/react/igr-ts/projects/top-nav/files/src/components/navigation-header/index.tsx | Refactors active nav item handling using memoized initial route matching. |
| packages/cli/templates/react/igr-ts/projects/_base/files/vite.config.ts | Updates Vitest browser config to use @vitest/browser-playwright provider helper. |
| packages/cli/templates/react/igr-ts/projects/_base/files/tsconfig.node.json | Adds node-specific TS config for Vite config type-checking. |
| packages/cli/templates/react/igr-ts/projects/_base/files/tsconfig.json | Switches to project references (tsconfig.app + tsconfig.node). |
| packages/cli/templates/react/igr-ts/projects/_base/files/tsconfig.app.json | Adds app TS config with updated target/libs and stricter linting flags. |
| packages/cli/templates/react/igr-ts/projects/_base/files/src/main.tsx | Updates React entrypoint imports/usage (StrictMode, createRoot). |
| packages/cli/templates/react/igr-ts/projects/_base/files/public/icons.svg | Adds SVG symbol sprite for social/documentation icons. |
| packages/cli/templates/react/igr-ts/projects/_base/files/public/favicon.svg | Adds new SVG favicon asset. |
| packages/cli/templates/react/igr-ts/projects/_base/files/public/favicon.ico | Existing favicon asset remains present in template. |
| packages/cli/templates/react/igr-ts/projects/_base/files/package.json | Updates dependencies/devDependencies and reorganizes scripts section. |
| packages/cli/templates/react/igr-ts/projects/_base/files/index.html | Updates favicon link and modernizes meta viewport/charset. |
| packages/cli/templates/react/igr-ts/projects/_base/files/eslint.config.mjs | Removes previous flat config implementation. |
| packages/cli/templates/react/igr-ts/projects/_base/files/eslint.config.js | Adds new ESLint flat config using typescript-eslint + globals. |
| packages/cli/templates/react/igr-ts/projects/_base/files/__dot__gitignore | Expands ignore patterns (logs/dist/editor files). |
| packages/cli/templates/react/igr-ts/projects/_base_with_home/files/index.html | Mirrors index.html head updates for the “with home” base template. |
| packages/cli/templates/react/igr-ts/pie-chart/default/files/src/app/path/filePrefix.tsx | Initializes chart data directly and wires legend via refs after mount. |
| packages/cli/templates/react/igr-ts/financial-chart/default/files/src/app/path/filePrefix.tsx | Simplifies chart data initialization by removing useEffect setter. |
| packages/cli/templates/react/igr-ts/doughnut-chart/default/files/src/app/path/filePrefix.tsx | Initializes chart data directly and assigns legend to series after mount. |
| packages/cli/templates/react/igr-ts/category-chart/default/files/src/app/path/filePrefix.tsx | Simplifies chart data initialization by removing useEffect setter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...cli/templates/react/igr-ts/projects/top-nav/files/src/components/navigation-header/index.tsx
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts/projects/_base/files/package.json
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts/projects/_base/files/__dot__gitignore
Outdated
Show resolved
Hide resolved
|
@copilot Fix the comments |
… duplicate eslint pkgs, dedup gitignore Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/7137d060-2cae-41c3-8cc9-6e5648084a6f Co-authored-by: Hristo313 <57346540+Hristo313@users.noreply.github.com>
Fixed all four review comments in commit d99cc9c:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
navigation-header/index.tsx: UseuseLocationto derive active item dynamically on route changespackage.jsonbuild script: Changetsctotsc -bfor project references supportpackage.jsondevDependencies: Remove redundant@typescript-eslint/eslint-pluginand@typescript-eslint/parser(already covered bytypescript-eslintmeta-package)__dot__gitignore: Deduplicate repeated entries (node_modules,.DS_Store,*-debug.log*patterns)Closes Update the igr-ts template #1552