Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the igr-ts React chart templates to remove the previous useEffect/useRef approach and instead initialize chart data via useState, while wiring chart legends through state-set refs.
Changes:
- Replace
useEffect-initialized chart data withuseState(data)initialization in several chart templates. - Replace
useReflegend wiring with a state-driven legend instance set viaref. - Add a React template-related entry to the changelog (currently mismatched with the actual PR changes).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/templates/react/igr-ts/pie-chart/default/files/src/app/path/filePrefix.tsx | Switches legend wiring to state and removes useEffect/useRef usage. |
| packages/cli/templates/react/igr-ts/doughnut-chart/default/files/src/app/path/filePrefix.tsx | Switches legend wiring to state and removes useEffect/useRef usage. |
| packages/cli/templates/react/igr-ts/financial-chart/default/files/src/app/path/filePrefix.tsx | Initializes chart data directly from useState(data) instead of an effect. |
| packages/cli/templates/react/igr-ts/category-chart/default/files/src/app/path/filePrefix.tsx | Initializes chart data directly from useState(data) instead of an effect. |
| CHANGELOG.md | Adds a React template bullet (currently describing Vite@8 rather than the chart-template changes in this PR). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cli/templates/react/igr-ts/pie-chart/default/files/src/app/__path__/__filePrefix__.tsx
Outdated
Show resolved
Hide resolved
.../cli/templates/react/igr-ts/doughnut-chart/default/files/src/app/__path__/__filePrefix__.tsx
Outdated
Show resolved
Hide resolved
...cli/templates/react/igr-ts/financial-chart/default/files/src/app/__path__/__filePrefix__.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Hristo313 <57346540+Hristo313@users.noreply.github.com>
2c4885f to
b145245
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kdinev
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small addition to #1598 where we discarded the effect approach. Actual clean approach is with state and works just fine
https://codesandbox.io/p/devbox/brave-wescoff-mrkqy2?file=%2Fsrc%2Findex.tsx%3A38%2C9-51%2C28