Fix unsigned authentication request to POST endpoint

[RouganStriker]

• Fix error casting request_xml to bytes when request_xml is an object
  • If the message does not get signed, pysaml2 will return an AuthNRequest object which can't be casted to a binary
  • Related to base_client's create_authn_request method returns different types depending on parameters pysaml2#570

Fixes #168

[RouganStriker]

@knaperek are build checks disabled for PRs in this project? Because the last 5 commits that went into the master branch all have failing tests.

[peppelinux]

@RouganStriker have you tested allow_create?

I'll check It tomorrow and I'll report here, if something changed and why I coded that way.

Regarding bytes/str We know about this issues with latests Django released. We should find a compatibile patch for all the supported django releases

Nice shoot

[RouganStriker]

@RouganStriker have you tested allow_create?

I verified that the attribute was being set in the AuthenticationRequest. Much appreciated if you could test it out as well since I don't have an instance that uses that attribute.

[peppelinux]

thank you @RouganStriker with this we should definitely made the code better in readability and without ambiguity:
#169

tested

[RouganStriker]

thank you @RouganStriker with this we should definitely made the code better in readability and without ambiguity:
#169

tested

Looks fine to me; I'm not going to pull it into this PR since you already made one for that.

And all tests are fixed now with the latest commit.

[agladboy]

@RouganStriker Is there any chance we can get this fixing merged to the master soon.

[RouganStriker]

@RouganStriker Is there any chance we can get this fixing merged to the master soon.

I need to revisit this MR, some fixes covered by this PR have been merged in via other PRs.

[RouganStriker]

@knaperek could you take a look at this PR?

CI checks failed since the master branch is failing as well.

[peppelinux]

I see. Py38 seems to have a different ordering on those string chunks.
Take your time, Hope to do a complete revision this week on pending PRs

@RouguanStriker I think that this is an important PR for v0.18.2, please resolve conflicts and don't worry about the concurrent PR, that's my business, do the things how you think that they should be done, we're ready for merge

[mhindery]

Regarding the failing tests (and them being disabled), this gets fixed with #186

[peppelinux]

Regarding the failing tests (and them being disabled), this gets fixed with #186

Let's complete the revision on that PR, meanwhile this PR can be merged as is, just a final check by his author I think that's needed

[peppelinux]

thank you @RouganStriker without your help I would not have the possibility to find this bug, I use signed authn requests