Fix HSL messages not being sent on wifi interface#2408
Draft
rmburg wants to merge 1 commit intoHULKs:mainfrom
Draft
Fix HSL messages not being sent on wifi interface#2408rmburg wants to merge 1 commit intoHULKs:mainfrom
rmburg wants to merge 1 commit intoHULKs:mainfrom
Conversation
knoellle
reviewed
Mar 25, 2026
Comment on lines
+36
to
+41
| let hsl_socket = UdpSocket::bind(SocketAddrV4::new( | ||
| Ipv4Addr::new(10, 0, 0, 0), | ||
| parameters.hsl, | ||
| )) | ||
| .await | ||
| .map_err(Error::CannotBind)?; |
Member
There was a problem hiding this comment.
This errors on startup :(
Error:
0: failed to initialize HSL network
1: failed to bind socket
Member
Author
There was a problem hiding this comment.
Thanks for testing this, I'll look into it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
The issue in #2369 was caused by the UDP broadcast packet ending up on the ethernet interface on the back of the robot instead of the wifi interface.
This is due to the fact that the robot has a default route on the ethernet interface, needed for internet connectivity.
We used to broadcast on an unspecified address, which was only sent on the default route.
ToDo / Known Issues
Completely untested as of yet
Ideas for Next Iterations (Not This PR)
Don't hardcode the 10.0.0.0/16 subnet?
alternatives considered:
How to Test
Check if our message count decreases in the game controller