Open
Conversation
schluis
requested changes
Jul 20, 2025
| pub outer_minimum_pitch: f32, | ||
| pub outer_yaw: f32, | ||
| pub injected_head_joints: Option<HeadJoints<f32>>, | ||
| pub filter_smoothing_factor: f32, |
Contributor
There was a problem hiding this comment.
Suggested change
| pub filter_smoothing_factor: f32, | |
| pub smoothing_factor: f32, |
| let positions = request.positions; | ||
| let last_positions = self.last_request.positions; | ||
|
|
||
| let velocity_limited_positions = HeadJoints { |
Contributor
There was a problem hiding this comment.
Please remove velocity limiting
Contributor
|
Hammerding 🥵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
Use lowpass filter for all head movements.
Fixes #2052
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Describe how to test your changes. (For the reviewer)