Skip to content

Convert anim, gfx and spell definitions to objects and tables #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 7 commits into from
Apr 29, 2026

Fix tests

c3df229
Select commit
Loading
Failed to load commit list.
Merged

Convert anim, gfx and spell definitions to objects and tables #964

Fix tests
c3df229
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2026 in 0s

37.71% (+0.01%) compared to 5402313

View this Pull Request on Codecov

37.71% (+0.01%) compared to 5402313

Details

Codecov Report

❌ Patch coverage is 53.67965% with 107 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.71%. Comparing base (5402313) to head (c3df229).

Files with missing lines Patch % Lines
...orld/gregs/voidps/engine/data/definition/Tables.kt 33.33% 9 Missing and 5 partials ⚠️
...main/kotlin/content/entity/player/combat/Attack.kt 33.33% 6 Missing and 4 partials ⚠️
...d/gregs/voidps/engine/data/config/RowDefinition.kt 0.00% 9 Missing ⚠️
game/src/main/kotlin/content/skill/magic/Magic.kt 78.12% 2 Missing and 5 partials ⚠️
game/src/main/kotlin/Main.kt 0.00% 6 Missing ⚠️
...dps/engine/data/definition/AnimationDefinitions.kt 69.23% 4 Missing ⚠️
...oidps/engine/data/definition/GraphicDefinitions.kt 69.23% 4 Missing ⚠️
...content/skill/magic/book/modern/TelekineticGrab.kt 50.00% 3 Missing and 1 partial ⚠️
...n/content/skill/magic/book/modern/TeleportOther.kt 42.85% 3 Missing and 1 partial ⚠️
...nt/entity/player/command/PlayerUpdatingCommands.kt 25.00% 3 Missing ⚠️
... and 27 more
Additional details and impacted files
Files with missing lines Coverage Δ
.../kotlin/world/gregs/voidps/engine/EngineModules.kt 0.00% <ø> (ø)
...rc/main/kotlin/content/entity/combat/hit/Damage.kt 65.51% <100.00%> (+2.29%) ⬆️
...src/main/kotlin/content/entity/gfx/SpawnGraphic.kt 100.00% <100.00%> (ø)
.../kotlin/content/entity/npc/combat/magic/Wizards.kt 55.55% <100.00%> (ø)
...n/content/entity/player/combat/CombatExperience.kt 75.60% <100.00%> (ø)
...content/entity/player/command/InterfaceCommands.kt 24.73% <100.00%> (-0.81%) ⬇️
...n/content/entity/player/dialogue/DialogueCommon.kt 100.00% <100.00%> (ø)
...kotlin/content/skill/magic/book/lunar/CurePlant.kt 54.54% <100.00%> (-1.98%) ⬇️
.../kotlin/content/skill/magic/book/modern/Alchemy.kt 77.77% <100.00%> (ø)
.../kotlin/content/skill/magic/book/modern/BonesTo.kt 85.18% <100.00%> (-0.53%) ⬇️
... and 40 more 
@@             Coverage Diff              @@
##               main     #964      +/-   ##
============================================
+ Coverage     37.70%   37.71%   +0.01%     
- Complexity     8132     8163      +31     
============================================
  Files          1680     1678       -2     
  Lines         67365    67398      +33     
  Branches      16825    16839      +14     
============================================
+ Hits          25397    25419      +22     
+ Misses        36286    36281       -5     
- Partials       5682     5698      +16
Components Coverage Δ
Content 35.73% <56.96%> (-0.02%) ⬇️
Engine 45.38% <45.45%> (+0.14%) ⬆️
Network 60.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov