Skip to content

Convert anim, gfx and spell definitions to objects and tables#964

Merged
GregHib merged 7 commits intomainfrom
anim-gfx-defs
Apr 29, 2026
Merged

Convert anim, gfx and spell definitions to objects and tables#964
GregHib merged 7 commits intomainfrom
anim-gfx-defs

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Apr 29, 2026

  • Convert animation & graphic definitions to objects Make all definitions static #839
  • Add table column support for animations and graphics
  • Add row cloning support
  • Convert SpellDefinitions to spell.tables.toml
  • Fix telegrab and tele other attacking npcs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 53.67965% with 107 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.71%. Comparing base (5402313) to head (c3df229).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...orld/gregs/voidps/engine/data/definition/Tables.kt 33.33% 9 Missing and 5 partials ⚠️
...main/kotlin/content/entity/player/combat/Attack.kt 33.33% 6 Missing and 4 partials ⚠️
...d/gregs/voidps/engine/data/config/RowDefinition.kt 0.00% 9 Missing ⚠️
game/src/main/kotlin/content/skill/magic/Magic.kt 78.12% 2 Missing and 5 partials ⚠️
game/src/main/kotlin/Main.kt 0.00% 6 Missing ⚠️
...dps/engine/data/definition/AnimationDefinitions.kt 69.23% 4 Missing ⚠️
...oidps/engine/data/definition/GraphicDefinitions.kt 69.23% 4 Missing ⚠️
...content/skill/magic/book/modern/TelekineticGrab.kt 50.00% 3 Missing and 1 partial ⚠️
...n/content/skill/magic/book/modern/TeleportOther.kt 42.85% 3 Missing and 1 partial ⚠️
...nt/entity/player/command/PlayerUpdatingCommands.kt 25.00% 3 Missing ⚠️
... and 27 more
Additional details and impacted files
Files with missing lines Coverage Δ
.../kotlin/world/gregs/voidps/engine/EngineModules.kt 0.00% <ø> (ø)
...rc/main/kotlin/content/entity/combat/hit/Damage.kt 65.51% <100.00%> (+2.29%) ⬆️
...src/main/kotlin/content/entity/gfx/SpawnGraphic.kt 100.00% <100.00%> (ø)
.../kotlin/content/entity/npc/combat/magic/Wizards.kt 55.55% <100.00%> (ø)
...n/content/entity/player/combat/CombatExperience.kt 75.60% <100.00%> (ø)
...content/entity/player/command/InterfaceCommands.kt 24.73% <100.00%> (-0.81%) ⬇️
...n/content/entity/player/dialogue/DialogueCommon.kt 100.00% <100.00%> (ø)
...kotlin/content/skill/magic/book/lunar/CurePlant.kt 54.54% <100.00%> (-1.98%) ⬇️
.../kotlin/content/skill/magic/book/modern/Alchemy.kt 77.77% <100.00%> (ø)
.../kotlin/content/skill/magic/book/modern/BonesTo.kt 85.18% <100.00%> (-0.53%) ⬇️
... and 40 more
@@             Coverage Diff              @@
##               main     #964      +/-   ##
============================================
+ Coverage     37.70%   37.71%   +0.01%     
- Complexity     8132     8163      +31     
============================================
  Files          1680     1678       -2     
  Lines         67365    67398      +33     
  Branches      16825    16839      +14     
============================================
+ Hits          25397    25419      +22     
+ Misses        36286    36281       -5     
- Partials       5682     5698      +16     
Components Coverage Δ
Content 35.73% <56.96%> (-0.02%) ⬇️
Engine 45.38% <45.45%> (+0.14%) ⬆️
Network 60.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 76b7682 into main Apr 29, 2026
5 checks passed
@GregHib GregHib deleted the anim-gfx-defs branch April 29, 2026 13:48
HarleyGilpin added a commit to HarleyGilpin/void that referenced this pull request Apr 29, 2026
…spells.bind

Tables.readTableRow resolves clone = "..." by trailing rowId only, so the
spell_projectiles.bind (4 cols) and spells.bind (17 cols) rows from GregHib#964
collided. The 4-column row was returned for [.snare]/[.entangle] clones in
spells, throwing ArrayIndexOutOfBoundsException at boot before the Koin
graph could finish.

Renamed the projectile row to bind_projectile and updated the one self-
reference in spells.bind.projectiles. No engine change — Tables.kt and the
rest of GregHib#964's refactor are byte-identical to upstream.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant