Skip to content

Conversation

@Little-King2022
Copy link
Contributor

Fix: #1158
下载没有扩展名的文件时也可以进行自动重命名

Web端测试:
image

本地下载目录:
image

@monkeyWie monkeyWie added the bug Something isn't working label Nov 14, 2025
@monkeyWie
Copy link
Member

非常感谢,CI没问题的话就merge了

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.17%. Comparing base (07dc196) to head (05e8287).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   65.89%   68.17%   +2.28%     
==========================================
  Files          42       42              
  Lines        5075     4207     -868     
==========================================
- Hits         3344     2868     -476     
+ Misses       1412     1020     -392     
  Partials      319      319              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@monkeyWie monkeyWie merged commit 1b36ed1 into GopeedLab:main Nov 14, 2025
10 of 11 checks passed
@Little-King2022
Copy link
Contributor Author

@monkeyWie
非常抱歉,刚才提交的代码只能处理前5个文件的重命名(因为最大下载数默认为5),后续的文件仍然无法重命名。

似乎不仅仅是这段代码的问题,第二批下载的文件并没有调用重名检查逻辑

以下是大于5个文件的下载情况,只有第一批的文件重命名成功了:
image

以下是本地下载路径:
image

非常抱歉我这边没有测试完第二批就忙着提交了🥲

@monkeyWie
Copy link
Member

monkeyWie commented Nov 15, 2025

我看了下新的pr,感觉问题没这么简单,如果把wait状态的任务也加上的话会导致暂停然后恢复下载的任务进入wait状态了,就会抛弃本来已下载的文件,创建一个新的文件

@monkeyWie
Copy link
Member

这个应该是另一个问题了,要再特殊处理下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 下载多个重名文件时,已下载的文件会被覆盖

2 participants