Skip to content

Conversation

@Little-King2022
Copy link
Contributor

Fix: #1173

Modified the isCreate condition in pkg/download/downloader.go to include DownloadStatusWait status, ensuring that duplicate file name checking and renaming logic is triggered for both initial downloads (Ready status) and subsequent batch downloads (Wait status).

This fix #1173 where only the first 5 files would be renamed on conflict, while subsequent batch files would fail to check for existing files and potentially overwrite them.

Screenshot shows that duplicate file name have been correctly renamed:
image

Screenshot of the local download path:
image

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.10%. Comparing base (1b36ed1) to head (173f15e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
- Coverage   68.17%   68.10%   -0.08%     
==========================================
  Files          42       42              
  Lines        4207     4207              
==========================================
- Hits         2868     2865       -3     
- Misses       1021     1023       +2     
- Partials      318      319       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant