Open
Conversation
Collaborator
Author
|
needs more work for bundling |
Collaborator
Author
|
new CharacterSet insight, gotta add it https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7577714 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft because my corp machine is preventing me from runningPaul published it for me.npm publish. New behavior, don't know how to fix it yet. So I can't actually pull in the new code in this PR, but I verified it works locally.0.0.61 to 0.0.64 changelog (all of devtools): ChromeDevTools/devtools-frontend@5e6608e...776967b
git log 5e6608ed73149c4453a001ec2845626a65fbfa1d...776967b00c -- front_end/models/trace:Changelog (just front_end/models/trace, mostly relevant to our usage in LH)
Many changes relevant to LH:
traceEngineResult.insightsmap is no longer key'd by navigation idinsights.modelErrorsnot ininsights.model