convert_bufr update: bufr-query bufr2netcdf.x #741
Merged
Conversation
…emoved yamls that are not compatible with the new converter. Reworked bufr_to_ioda.py - dont need to generated, or edit, the ioda conv yaml contents with new converter.
…fr2netcdf.x. New yamls added to new directory. Working.
…commented out. Cleaned bufr2netcdf yamls.
Updating local branch.
mranst
requested changes
Apr 29, 2026
Collaborator
mranst
left a comment
There was a problem hiding this comment.
Nice, I was able to run the conversion successfully. I would have a look at some of the try-catch logic in BufrToIoda, I think you're going to end up passing some issues that should really cause an error, like not being able to find the jedi executable.
Collaborator
|
FYI @ftgoktas this PR changes how the BufrToIoda task works - I think you mentioned you were using it |
Co-authored-by: Michael Anstett <michael.anstett@nasa.gov>
…a files now have sat_name and satid in the file name (e.g., cosmic2_755). File Cleanup: convert_bufr now removes leftover temporary.nc files that don't get renamed due to an existing file
mranst
reviewed
May 7, 2026
Collaborator
mranst
left a comment
There was a problem hiding this comment.
A few notes, otherwise I think it's ready
mranst
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated 05-06-2026:
Log edits and error handling cleanup
Ouptut ioda files now have sat_name and satid in the file name (e.g.,
cosmic2_755)File Cleanup: convert_bufr will now remove the leftover 'temporary*.nc' files that don't get renamed due to an existing converted file for that obstype date
To Do:
Updating the
bufr_to_ioda.pytask from the convert_bufr suite to use the new executablebufr2netcdf.xfrombufr-query. The previous executablebufr2ioda.xis deprecated.bufr2netcdf.xandbufr2ioda.xeach require a specific yaml file format so a new yaml directory was added for thebufr2netcdf.xspecific yamls for all SPOC yamls (https://github.com/NOAA-EMC/spoc/tree/develop/dump/config/atmosphere).Produces one file for each satid ('{splits/satd}' method).
The key changes to
bufr_to_ioda.pywere:bufr2ioda.x [bufr file] [bufr_mapping.yaml]tobufr2netcdf.x [bufr file] [bufr_mapping.yaml]convert_bufr/suite_config.pyand question defaultsconfiguration/jedi/bufr2ioda/bufr2netcdf_x/Impact
Should make the next set of changes easier if/when we integrate the use of the
bufr-queryObsBuilderTesting
Swell SPOC yaml testing convert_bufr
spoc_prepbufr_aircraft.yamlacft_profiles).spoc_radiance_1bamua.yamlspoc_radiance_1bmhs.yamlspoc_radiance_amsr2.yamlspoc_radiance_amsua_1bamua.yamlspoc_radiance_amsua_esamua.yamlspoc_radiance_atms.yamlspoc_radiance_avcsam.yamlspoc_radiance_avcspm.yamlspoc_radiance_avhrr.yamlspoc_radiance_cris-fsr.yamlspoc_radiance_gmi.yamlspoc_radiance_gpsro.yamlspoc_radiance_iasi.yamlspoc_radiance_mtiasi.yamlandspoc_radiance_iasi.yamlmapped to mtiasi obs.spoc_radiance_mhs_1bmhs.yamlspoc_radiance_mtiasi.yamlspoc_radiance_ssmis.yamlspoc_retrieval_ozone_omi.yamlspoc_retrieval_ozone_ompslp.yamlspoc_retrieval_ozone_ompstc.yaml