Remove oomph/ and VarSpec files from generic/ (#4732)#4773
Merged
tclune merged 10 commits intorelease/MAPL-v3from May 6, 2026
Merged
Remove oomph/ and VarSpec files from generic/ (#4732)#4773tclune merged 10 commits intorelease/MAPL-v3from
tclune merged 10 commits intorelease/MAPL-v3from
Conversation
WRITE_PARALLEL from mapl3g_FileIO was not accessible via 'use MAPL', forcing components to import internal mapl3g_* modules directly. Adding it to mapl_base3g makes it available through the MAPL umbrella.
- Delete oomph/ subdirectory entirely (no longer used) - Delete VarSpec*.F90 files from generic/ (only used by oomph) - Remove add_subdirectory(oomph) from top-level CMakeLists.txt - Remove VarSpec sources and MAPL.oomph dep from generic/CMakeLists.txt - Remove dead VarSpec use statements from generic/MaplGeneric.F90 - Remove MAPL_VarSpec args from MAPL_GenericStateGet stub - Remove use MAPL_VarSpecMiscMod from MAPL/MAPL.F90
Collaborator
Author
|
Triggering CI rerun. |
tclune
added
0 Diff
pchakraborty
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oomph/subdirectory entirely (was only used by VarSpec)VarSpec*.F90files fromgeneric/(were only used by oomph)use mapl_VarSpec*statements fromgeneric/MaplGeneric.F90MAPL_VarSpecoptional args fromMAPL_GenericStateGetstubuse MAPL_VarSpecMiscModfromMAPL/MAPL.F90CMakeLists.txtfiles accordinglyMotivation
Part of issue #4732 — removing legacy MAPL2 infrastructure (
generic/andoomph/) that is no longer needed once all components have migrated to MAPL3 APIs.Dependencies
MAPL_GenericModsymbols in AdvCore)Closes #4732