Background
MAPL_VarSpecMiscMod (and related VarSpec files in generic/) are part of the legacy generic/ layer targeted for deletion. MAPL/MAPL.F90 (the MAPL2 aggregate) still has:
This is the last remaining use of a generic/ module in MAPL2 after #4731 lands.
Affected external consumers (in GEOSgcm_GridComp, all currently commented out in CMake)
GEOSgigatraj_GridComp
@StratChem, @CARMA, @GOCART, @RRG, @GMI
GEOSsatsim_GridComp, GEOSsolar_GridComp
These are all commented out on release/MAPL-v3 so they do not block this work. They will need porting to the MAPL3 VarSpec API when re-enabled.
Work required
- Drop
use MAPL_VarSpecMiscMod from MAPL/MAPL.F90
- Remove VarSpec source files from
generic/CMakeLists.txt
- Once
generic/ is otherwise empty, remove add_subdirectory(generic) and add_subdirectory(oomph) from the top-level CMakeLists.txt and delete both directories
Prerequisites
Depends on #4731 (remove MAPL_GenericMod and MAPL_OpenMP_Support from MAPL2).
Background
MAPL_VarSpecMiscMod(and related VarSpec files ingeneric/) are part of the legacygeneric/layer targeted for deletion.MAPL/MAPL.F90(theMAPL2aggregate) still has:This is the last remaining
useof ageneric/module inMAPL2after #4731 lands.Affected external consumers (in GEOSgcm_GridComp, all currently commented out in CMake)
GEOSgigatraj_GridComp@StratChem,@CARMA,@GOCART,@RRG,@GMIGEOSsatsim_GridComp,GEOSsolar_GridCompThese are all commented out on
release/MAPL-v3so they do not block this work. They will need porting to the MAPL3 VarSpec API when re-enabled.Work required
use MAPL_VarSpecMiscModfromMAPL/MAPL.F90generic/CMakeLists.txtgeneric/is otherwise empty, removeadd_subdirectory(generic)andadd_subdirectory(oomph)from the top-levelCMakeLists.txtand delete both directoriesPrerequisites
Depends on #4731 (remove
MAPL_GenericModandMAPL_OpenMP_Supportfrom MAPL2).