Migrate AdvCore_GridCompMod to MAPL3 APIs (#363)#364
Closed
tclune wants to merge 2 commits intorelease/MAPL-v3from
Closed
Migrate AdvCore_GridCompMod to MAPL3 APIs (#363)#364tclune wants to merge 2 commits intorelease/MAPL-v3from
tclune wants to merge 2 commits intorelease/MAPL-v3from
Conversation
This was referenced May 5, 2026
tclune
added
the
0 diff
tclune
force-pushed
the
feature/363-migrate-advcore-to-mapl3
branch
from
4d15710 to
6502df9
Compare
Collaborator
Author
|
Changes applied directly to release/MAPL-v3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdvCore_GridCompMod.F90from MAPL2 to MAPL3, removing alluse MAPL2dependenciesAdvCore_StateSpecs.rcto ACG v3 schema and enables ACG v3 inCMakeLists.txtMAPL2 → MAPL3 API changes
MAPL_GenericSetServices/Initialize/FinalizeMAPL_GetPointerMAPL_StateGetPointerMAPL_AddImportSpec/AddExportSpecMAPL_GridCompAddSpecMAPL_GetObjectFromGC+MAPL_GetMAPL_GridCompGet+MAPL_GridGetMAPL_GridCreateMAPL_GridCompSetGeometry(moved to SetServices)MAPL_FieldBundleAddESMF_FieldBundleAdd([field])MAPL_TimerAdd/On/OffMAPL_GridCompTimerStart/StopMAPL_GetResourceMAPL_GridCompGetResourceAll MAPL3 symbols accessed via
use MAPLumbrella only.Files removed
CreateInterpWeights.F90(dead code)CreateInterpWeights_GridCompMod.F90(dead code)Cube2LatLon.F90(dead code)LatLon2Cube.F90(dead code)Dependencies
Requires GEOS-ESM/MAPL#4772 to be merged first.
Closes #363