Skip to content

feat: remove operations from FiniteElementBase #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: remove operations from FiniteElementBase #3725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a0440d
remove operations from FiniteElementBase
rrsettgast Jul 13, 2025
7e40dad
remove numSupportPoints templated function in FiniteElementBase
rrsettgast Jul 14, 2025
53c986b
remove option to precalculate shape functions....this is never advant…
rrsettgast Jul 14, 2025
5e51028
fixed some compilation issues from last commit
rrsettgast Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ blt_add_executable( NAME geosx
${extraComponentsLinkList}
${externalComponentsLinkList} )

if(APPLE)
target_link_options(geosx PRIVATE "-Wl,-export_dynamic")
endif()


# Seems to be required on some CMake versions (e.g. 3.16) to get enforce device linking
if( ${ENABLE_HYPRE_DEVICE} STREQUAL "CUDA" )
set_target_properties( geosx PROPERTIES CUDA_RESOLVE_DEVICE_SYMBOLS TRUE )
Expand Down
1 change: 1 addition & 0 deletions src/coreComponents/finiteElement/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ set( finiteElement_headers
LinearFormUtilities.hpp
PDEUtilities.hpp
elementFormulations/FiniteElementBase.hpp
elementFormulations/FiniteElementOperators.hpp
elementFormulations/H1_Hexahedron_Lagrange1_GaussLegendre2.hpp
elementFormulations/H1_Pyramid_Lagrange1_Gauss5.hpp
elementFormulations/H1_QuadrilateralFace_Lagrange1_GaussLegendre2.hpp
Expand Down
2 changes: 1 addition & 1 deletion src/coreComponents/finiteElement/FiniteElementDiscretization.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ FiniteElementDiscretization::
typename FE_TYPE::StackVariables feStack;
finiteElement.template setup< FE_TYPE >( k, meshData, feStack );
real64 xLocal[numNodesPerElem][3];
localIndex numSupportPoints = finiteElement.template numSupportPoints< FE_TYPE >( feStack );
localIndex numSupportPoints = finiteElement.getNumSupportPoints( feStack );
for( localIndex a=0; a< numSupportPoints; ++a )
{
localIndex const nodeIndex = elemsToNodes[ k][ a ];
Expand Down
Loading
Loading