Skip to content

feat: remove operations from FiniteElementBase #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: remove operations from FiniteElementBase #3725

wants to merge 4 commits into from

Conversation

rrsettgast
Copy link
Member

This PR seeks to remove the issues caused by the virtual destructor in FIniteElementBase.

  • Remove operations from FiniteElementBase
  • Split derived types into virtual and non-virtual types.
  • use the non-virtual types in device kernels.

@rrsettgast rrsettgast self-assigned this Jul 13, 2025
@rrsettgast rrsettgast added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sframba sframba Awaiting requested review from sframba sframba is a code owner

@acitrain acitrain Awaiting requested review from acitrain acitrain is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@paveltomin paveltomin Awaiting requested review from paveltomin paveltomin is a code owner

@andrea-borio andrea-borio Awaiting requested review from andrea-borio andrea-borio is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@wrtobin wrtobin

@rrsettgast rrsettgast

Labels
ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrsettgast @wrtobin