-
Notifications
You must be signed in to change notification settings - Fork 56
refactor(breadcrumb): replace 'strong' with 'breadcrumb' tags #3043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(breadcrumb): replace 'strong' with 'breadcrumb' tags #3043
Conversation
…tro-breadcrumb # Conflicts: # astro/src/content/docs/_shared/_admin-user-form.mdx # astro/src/content/docs/_shared/_admin-user-registration-form.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - so many breadcrumbs, I feel like a duck!
thanks for the review @tonyblank while merging the latest updates i found a mistake in a few changes we did where it should have been replaced with |
…o-breadcrumb # Conflicts: # astro/src/content/docs/customize/email-and-messages/configure-email.mdx # astro/src/content/docs/customize/look-and-feel/index.mdx # astro/src/content/docs/extend/events-and-webhooks/signing.mdx
@alex-fusionauth I've merged the latest changes and updated some newly introduced The few ones unclear right now are the ones where it refers to navigate to a section rather a full page/tab. |
@alex-fusionauth defined the sections as a |
Here is a file of lines that in most cases need |
astro/src/content/docs/customize/email-and-messages/generic-messenger.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/docs/customize/email-and-messages/messengers.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/docs/lifecycle/authenticate-users/integrations/saml/pagerduty.mdx
Show resolved
Hide resolved
...ntent/docs/lifecycle/manage-users/account-management/_account-management-troubleshooting.mdx
Outdated
Show resolved
Hide resolved
...ntent/docs/lifecycle/manage-users/verification/registration-gate-accounts-until-verified.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Pai <[email protected]>
@andrewpai Working on this at the moment, and wanted to clarify, we will not only change the site content but all blog posts too with the same concept. And according to that i will update the blog section in DocsDevREADME.md with that guideline too. |
Correct, we should make our docs consistent across |
@andrewpai We discovered the issue that linting will complain about the usage of
|
# Conflicts: # astro/src/content/docs/_shared/_account-portal.mdx # astro/src/content/docs/apis/api-explorer.mdx # astro/src/content/docs/apis/login.mdx # astro/src/content/docs/apis/users.mdx # astro/src/content/docs/customize/look-and-feel/simple-theme-editor.mdx # astro/src/content/docs/extend/events-and-webhooks/index.mdx # astro/src/content/docs/extend/events-and-webhooks/signing.mdx # astro/src/content/docs/extend/examples/5-minute-intro/5-minute-fastpath.mdx # astro/src/content/docs/extend/examples/api-gateways/aws-api-gateway.mdx # astro/src/content/docs/extend/examples/api-gateways/ngrok-cloud-edge.mdx # astro/src/content/docs/get-started/_setting-up-portal-account.mdx # astro/src/content/docs/get-started/core-concepts/_multi-tenant-limitations.mdx # astro/src/content/docs/get-started/core-concepts/licensing.mdx # astro/src/content/docs/get-started/core-concepts/users.mdx # astro/src/content/docs/get-started/download-and-install/kubernetes/gke.mdx # astro/src/content/docs/get-started/run-in-the-cloud/github-actions.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/enterprise/okta-samlv2-idp-initiated.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/enterprise/samlv2-idp-initiated.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/overview-oidc.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/overview-samlv2.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/social/apple.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/social/google.mdx # astro/src/content/docs/lifecycle/authenticate-users/login-api/json-web-tokens.mdx # astro/src/content/docs/lifecycle/authenticate-users/multi-factor-authentication.mdx # astro/src/content/docs/lifecycle/authenticate-users/oauth/modes.mdx # astro/src/content/docs/lifecycle/authenticate-users/passwordless/magic-links.mdx # astro/src/content/docs/lifecycle/authenticate-users/setting-up-user-account-lockout.mdx # astro/src/content/docs/lifecycle/authenticate-users/single-sign-on.mdx # astro/src/content/docs/lifecycle/manage-users/account-management/_account-management-troubleshooting.mdx # astro/src/content/docs/lifecycle/manage-users/account-management/customizing-account-management.mdx # astro/src/content/docs/lifecycle/manage-users/search/user-search-with-elasticsearch.mdx # astro/src/content/docs/lifecycle/manage-users/user-actions.mdx # astro/src/content/docs/lifecycle/manage-users/verification/_common-questions-gating.mdx # astro/src/content/docs/lifecycle/migrate-users/connectors/generic-connector.mdx # astro/src/content/docs/lifecycle/migrate-users/general-migration.mdx # astro/src/content/docs/lifecycle/migrate-users/provider-specific/cognito.mdx # astro/src/content/docs/lifecycle/migrate-users/provider-specific/wordpress.mdx # astro/src/content/docs/lifecycle/migrate-users/scim/scim-sdk.mdx # astro/src/content/docs/operate/deploy/cluster.mdx # astro/src/content/docs/operate/deploy/user-support-guide.mdx # astro/src/content/docs/operate/secure/advanced-threat-detection.mdx # astro/src/content/docs/operate/troubleshooting/troubleshooting.mdx # astro/src/content/quickstarts/quickstart-swift-ios-native.mdx
@synedra @andrewpai @mooreds I would like to get this PR merged, after spending another 5 hours on it getting everything merged from main, and all strong, Breadcrumb, InlineField or InlineUIElement eslint errors fixed. On the eslint topic: I've run a check on all changed files and created a fix for the pr-linting #3600. The part which is still outstanding on how to handle the input in to InlineField as we cant use strong we need an additional definition for that e.g. InlineFieldInput. But I would suggest since we’re already having 311 files changed that we do this in a second iteration. |
# Conflicts: # astro/src/content/docs/extend/events-and-webhooks/webhook-event-log.mdx # astro/src/content/docs/lifecycle/authenticate-users/identity-providers/enterprise/azure-ad-saml.mdx
@andrewpai as discussed I merged the latest changes, updated all the newly added old-style breadcrumbs. In addition, I fixed some of the obvious link errors throughout the documents modified in this PR. |
solves issue FusionAuth/fusionauth-issues#2572