Skip to content

Conversation

Aaron-Ritter
Copy link
Contributor

@Aaron-Ritter Aaron-Ritter commented Oct 26, 2024

this provides the blog, documentation and quickstart documentation for the new fusionauth swift SDK https://github.com/FusionAuth/fusionauth-swift-sdk and quickstart https://github.com/FusionAuth/fusionauth-quickstart-swift-ios-native.

End2End Testing is implemented with the help of FusionAuth/homebrew-fusionauth#16.

@Aaron-Ritter Aaron-Ritter requested a review from synedra November 8, 2024 10:53
@Aaron-Ritter Aaron-Ritter marked this pull request as ready for review November 8, 2024 10:53
@Aaron-Ritter Aaron-Ritter requested review from a team as code owners November 8, 2024 10:53
@Aaron-Ritter Aaron-Ritter requested a review from a team as a code owner November 8, 2024 10:53
@Aaron-Ritter Aaron-Ritter removed the request for review from ColinFrick November 8, 2024 10:55
Copy link
Contributor

@synedra synedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, looks good to me.

@synedra synedra requested a review from johnjeffers February 19, 2025 18:22
@Aaron-Ritter
Copy link
Contributor Author

All references are updated to the FusionAuth repositories.
The following PRs have to be merged in the target repository, which have additional references that need to be updated.
FusionAuth/fusionauth-swift-sdk#53
FusionAuth/fusionauth-quickstart-swift-ios-native#13

Copy link
Contributor

@synedra synedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through all of the new documentation, it is clear and seems complete. There is a linting issue, which should probably be addressed before the final push.

@Aaron-Ritter
Copy link
Contributor Author

Read through all of the new documentation, it is clear and seems complete. There is a linting issue, which should probably be addressed before the final push.

@synedra I agree with you and have already mentioned this in my comments to the breadcrumb rework (which we currently put on hold because of the other priorities) #3043 (comment). The question now remains how to specify an Input in to an InlineField.

Copy link
Contributor

@synedra synedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is now functioning, LGTM.

@synedra synedra merged commit 5bae339 into FusionAuth:main Feb 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants