chore: code formatting and style cleanup #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply consistent formatting across base-action tests - Format README.md bullet points consistently - Minor whitespace and formatting fixes in various files Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
Droid finished @shashank-factory's task —— View job |
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
| "Only use LEFT when specifically referencing code being removed." | ||
| "Side of the diff to comment on: LEFT (old code) or RIGHT (new code). " + | ||
| "IMPORTANT: Use RIGHT for comments on new/modified code. " + | ||
| "Only use LEFT when specifically referencing code being removed.", |
Contributor
There was a problem hiding this comment.
[P1] Accept line=0 instead of treating it as missing
if (!line && !startLine) treats line=0 as missing because 0 is falsy; since your schema allows .nonnegative(), a caller can pass 0 and get an incorrect validation error—use line == null / startLine == null checks instead.
Contributor
There was a problem hiding this comment.
Overall: mostly formatting-only changes, but there is a behavior bug in the inline-comment MCP server where line=0 (allowed by schema) is treated as missing due to a falsy check. Fixing the line/startLine presence checks should make the tool’s validation consistent with the zod schema.
This was referenced Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code formatting and style cleanup - no functional changes.
Changes
This PR is part of a split from the security review feature branch to make reviews easier.
PR Stack