feat: change review output to JSON format #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply consistent formatting across base-action tests - Format README.md bullet points consistently - Minor whitespace and formatting fixes in various files Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Add support for security-focused code review commands: - @droid security - Security review on PR changes - @droid security --full - Full repository security scan New features: - Security command parser (security, review-security, security-full) - Security review prompt with STRIDE methodology - Security scan prompt with threat model generation - Security configuration inputs in action.yml - Security-specific tracking comment message Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Changes look correct: they update the review prompt/template and tests to switch the code-review step to JSON-file output plus updating a tracking comment, and they remove inline-commenting guidance from the prompt. No high-severity issues found in this PR’s changes.
- Fix SECURITY_SCAN_DAYS to avoid NaN (clamp to positive integer, default 7) - Remove instructions to commit threat model to PR branch during review - Remove instructions to commit patches to PR branch - Align security review with JSON output pattern (no direct inline comments) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Update review prompt to output findings to JSON file instead of posting inline comments directly. This enables the parallel workflow to combine code review and security review findings before posting. Changes: - Review writes findings to code-review-results.json - Tracking comment updated with summary table - Inline comments deferred to finalize step Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
shashank-factory
force-pushed
the
ssharma/pr3-review-json-output
branch
from
394437b to
6d909b9
Compare
varin-nair-factory
force-pushed
the
ssharma/pr2-security-commands
branch
from
dff43cf to
01e9df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update review prompt to output findings to JSON file instead of posting inline comments directly.
Why This Change
This enables the parallel workflow (PR4) to combine code review and security review findings before posting, avoiding overlapping inline comments.
Changes
code-review-results.jsonThis PR is part of a split from the security review feature branch.
PR Stack