Skip to content

Running tests for NBs 7685 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 25, 2025
Merged

Running tests for NBs 7685 #262

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
bb90425
tmp: new run jl tests
VsevolodX Aug 8, 2025
d9ee356
tmp: run nb healthchecks
VsevolodX Aug 8, 2025
f229198
tmp: new run jl tests
VsevolodX Aug 8, 2025
4a51a60
update: fix a test
VsevolodX Aug 9, 2025
3d7d088
update: dynamical origin url
VsevolodX Aug 9, 2025
79b8e6d
update: dynamical running of notebooks healthchecks
VsevolodX Aug 9, 2025
967a7e0
update: dynamical running of notebooks healthchecks
VsevolodX Aug 9, 2025
3b1d9b1
tmp: set dev url
VsevolodX Aug 9, 2025
916c985
update: use vite
VsevolodX Aug 9, 2025
8febe85
update: cleanup
VsevolodX Aug 10, 2025
a627bc0
update: description of JL URL env
VsevolodX Aug 11, 2025
9b111ef
try: check to run healthchecks
VsevolodX Aug 11, 2025
082c46b
update: more coorect way to set JL flag
VsevolodX Aug 11, 2025
255b5ca
update: dockefile
VsevolodX Aug 11, 2025
8c08ef1
update: dockerfile
VsevolodX Aug 11, 2025
3707758
update: pass flag to GH
VsevolodX Aug 11, 2025
d10c27d
tmp: for ax tests
VsevolodX Aug 24, 2025
934b3d0
tmp: for ax tests
VsevolodX Aug 24, 2025
5918486
update: adjustment to run health checks
VsevolodX Aug 24, 2025
53ee515
chore: move url to env
VsevolodX Aug 25, 2025
a642fb7
chore: move url to env
VsevolodX Aug 25, 2025
560a006
chore: set to false
VsevolodX Aug 25, 2025
a67a6c0
chore: fix a typo
VsevolodX Aug 25, 2025
64bd250
try: dont run hc
VsevolodX Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/components/include/jupyterlite/BaseJupyterLiteComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class BaseJupyterLiteSessionComponent extends React.Component {
}
}
render() {
return (_jsx(JupyterLiteSession, { defaultNotebookPath: this.DEFAULT_NOTEBOOK_PATH, messageHandlerConfigs: this.messageHandlerConfigs, ref: this.jupyterLiteSessionRef }));
return (_jsx(JupyterLiteSession, { originURL: "https://deploy-preview-56--mat3ra-jupyterlite.netlify.app", defaultNotebookPath: this.DEFAULT_NOTEBOOK_PATH, messageHandlerConfigs: this.messageHandlerConfigs, ref: this.jupyterLiteSessionRef }));
}
}
export default BaseJupyterLiteSessionComponent;
1 change: 1 addition & 0 deletions src/components/include/jupyterlite/BaseJupyterLiteComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ class BaseJupyterLiteSessionComponent<P = never, S = never> extends React.Compon
render() {
return (
<JupyterLiteSession
originURL="https://deploy-preview-56--mat3ra-jupyterlite.netlify.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe get this from a settings file with the following logic: if development profile, use https://deploy-preview-{JupyterLitePullRequestNumber}--mat3ra-jupyterlite.netlify.app. So that you only need to update:

isDevelopment: true, JupyterLitePullRequestNumber: 56

defaultNotebookPath={this.DEFAULT_NOTEBOOK_PATH}
messageHandlerConfigs={this.messageHandlerConfigs}
ref={this.jupyterLiteSessionRef}
Expand Down
2 changes: 1 addition & 1 deletion tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "index.js",
"scripts": {
"test": "CYPRESS_BASE_URL=${CYPRESS_BASE_URL:-'http://localhost:3001'} cypress open",
"test:headless": "export TAGS=${TAGS:-'not @ignore and not @notebook_healthcheck'}; CYPRESS_BASE_URL=${CYPRESS_BASE_URL:-'http://localhost:3001'} cypress run -e TAGS=\"$TAGS\"",
"test:headless": "export TAGS=${TAGS:-'not @ignore'}; CYPRESS_BASE_URL=${CYPRESS_BASE_URL:-'http://localhost:3001'} cypress run -e TAGS=\"$TAGS\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USE_JUPYTERLITE_DEV_URL=false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inside settings.js

const JUPYTERLITE_DEVELOPMENT_URL = "";
const JUPYTERLITE_PRODUCTION_URL = "";
const URL = env('USE_JUPYTERLITE_DEV_URL') ? DEV_URL : PROD_URL

"test:healthcheck": "TAGS='not @ignore and @notebook_healthcheck' npm run test:headless",
"lint": "npx eslint cypress && prettier --write cypress"
},
Expand Down
Loading