Running tests for NBs 7685 #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mat3ra-materials-designer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| render() { | ||
| return ( | ||
| <JupyterLiteSession | ||
| originURL="https://deploy-preview-56--mat3ra-jupyterlite.netlify.app" |
There was a problem hiding this comment.
Maybe get this from a settings file with the following logic: if development profile, use https://deploy-preview-{JupyterLitePullRequestNumber}--mat3ra-jupyterlite.netlify.app. So that you only need to update:
isDevelopment: true, JupyterLitePullRequestNumber: 56
timurbazhirov
approved these changes
Aug 8, 2025
tests/package.json
Outdated
| "scripts": { | ||
| "test": "CYPRESS_BASE_URL=${CYPRESS_BASE_URL:-'http://localhost:3001'} cypress open", | ||
| "test:headless": "export TAGS=${TAGS:-'not @ignore and not @notebook_healthcheck'}; CYPRESS_BASE_URL=${CYPRESS_BASE_URL:-'http://localhost:3001'} cypress run -e TAGS=\"$TAGS\"", | ||
| "test:headless": "export TAGS=${TAGS:-'not @ignore'}; CYPRESS_BASE_URL=${CYPRESS_BASE_URL:-'http://localhost:3001'} cypress run -e TAGS=\"$TAGS\"", |
There was a problem hiding this comment.
USE_JUPYTERLITE_DEV_URL=false
There was a problem hiding this comment.
inside settings.js
const JUPYTERLITE_DEVELOPMENT_URL = "";
const JUPYTERLITE_PRODUCTION_URL = "";
const URL = env('USE_JUPYTERLITE_DEV_URL') ? DEV_URL : PROD_URL
timurbazhirov
approved these changes
Aug 9, 2025
dist/settings.js
Outdated
| export const theme = DarkMaterialUITheme; | ||
| // get from https://github.com/Exabyte-io/jupyterlite/pull/N | ||
| const JUPYTERLITE_DEVELOPMENT_URL = "https://deploy-preview-56--mat3ra-jupyterlite.netlify.app"; | ||
| export const ORIGIN_URL = import.meta.env.VITE_USE_JUPYTERLITE_DEV_URL |
There was a problem hiding this comment.
Should be process.env.USE_JUPYTERLITE_DEV_URL
dist/settings.js
Outdated
| export const theme = DarkMaterialUITheme; | ||
| // get from https://github.com/Exabyte-io/jupyterlite/pull/N | ||
| const JUPYTERLITE_DEVELOPMENT_URL = "https://deploy-preview-56--mat3ra-jupyterlite.netlify.app"; | ||
| export const ORIGIN_URL = import.meta.env.VITE_USE_JUPYTERLITE_DEV_URL |
timurbazhirov
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.