Skip to content

Use pytest everywhere#138

Merged
joanise merged 4 commits intomainfrom
dev.ej/full-pytest
May 1, 2026
Merged

Use pytest everywhere#138
joanise merged 4 commits intomainfrom
dev.ej/full-pytest

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Apr 29, 2026

joanise added 4 commits April 29, 2026 09:40
1) they don't actually work with pytest, so we had disabled them

2) at this point they're always disabled since we always import pytest

3) the problem they address is handled correctly by pytest, since unlike
unittest it captures all output and only shows it on demand and/or on error.
@joanise joanise requested a review from roedoejet April 29, 2026 18:21
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 29, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/tests/test_writing_callbacks.py  95% smaller
  fs2/tests/test_cli.py  93% smaller
  fs2/tests/test_loading.py  91% smaller
  fs2/tests/test_chunking.py  76% smaller
  .coveragerc Unsupported file format
  .github/workflows/test.yml  0% smaller
  fs2/run_tests.py  0% smaller

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.88%. Comparing base (8f1f4ea) to head (5840db6).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   49.69%   47.88%   -1.82%     
==========================================
  Files          27       27              
  Lines        1988     1988              
  Branches        0      225     +225     
==========================================
- Hits          988      952      -36     
  Misses       1000     1000              
- Partials        0       36      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise
Copy link
Copy Markdown
Member Author

joanise commented Apr 29, 2026

Coverage went down because I enabled branch coverage. If you count Hits+Partials how, you get what we had for Hits before.

Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joanise joanise merged commit 5840db6 into main May 1, 2026
6 of 7 checks passed
@joanise joanise deleted the dev.ej/full-pytest branch May 1, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants