Skip to content

Use pytest everywhere#792

Merged
joanise merged 7 commits intomainfrom
dev.ej/full-pytest
May 1, 2026
Merged

Use pytest everywhere#792
joanise merged 7 commits intomainfrom
dev.ej/full-pytest

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Apr 29, 2026

PR Goal?

Make pytest the way we run tests in every circumstance.

At the same time, I removed silence_c_str{err,out} because they do nothing when using pytest.

How to test?

  • run pytest
  • everyvoice/run_tests.py does effectively the same, but it still has suites, and --describe
  • see CI logs for tests using pytest in that context

Confidence?

high

Version change?

no

Related PRs?

EveryVoiceTTS/wav2vec2aligner#29
EveryVoiceTTS/FastSpeech2_lightning#138

joanise added 2 commits April 29, 2026 13:17
1) they don't actually work with pytest, so we had disabled them

2) at this point they're always disabled since we always import pytest

3) the problem they address is handled correctly by pytest, since unlike
unittest it captures all output and only shows it on demand and/or on error.
@joanise joanise requested a review from roedoejet April 29, 2026 18:20
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 29, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/tests/test_model.py  92% smaller
  everyvoice/tests/test_text.py  81% smaller
  everyvoice/tests/test_cli.py  79% smaller
  everyvoice/tests/test_preprocessing.py  76% smaller
  everyvoice/tests/test_utils.py  67% smaller
  everyvoice/tests/test_evaluation.py  63% smaller
  everyvoice/tests/model_stubs.py  56% smaller
  everyvoice/tests/test_dataloader.py  50% smaller
  everyvoice/tests/test_doctests.py  50% smaller
  everyvoice/tests/regression/test-demo-app-lj-full.py  42% smaller
  everyvoice/tests/regression/test-demo-app-mix.py  42% smaller
  everyvoice/tests/test_wizard.py  28% smaller
  everyvoice/run_tests.py  22% smaller
  .github/workflows/test.yml  20% smaller
  everyvoice/tests/test_subsample.py  15% smaller
  .github/workflows/matrix-tests.yml  0% smaller
  README.md Unsupported file format
  everyvoice/cli.py  0% smaller
  everyvoice/model/aligner/wav2vec2aligner  0% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  everyvoice/tests/preprocessed_audio_fixture.py  0% smaller
  everyvoice/tests/stubs.py  0% smaller
  everyvoice/tests/test_configs.py  0% smaller
  everyvoice/tests/test_custom_g2p.py  0% smaller
  everyvoice/tests/test_wizard_helpers.py  0% smaller
  pyproject.toml Unsupported file format

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

CLI load time: 0:00.30
Pull Request HEAD: d636890800510ff12bc7ff6df3a6e5b55a837775
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1487 |     163840 | everyvoice.cli

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (8eff9e5) to head (d636890).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          47       47           
  Lines        4203     4203           
  Branches      615      615           
=======================================
  Hits         3506     3506           
  Misses        567      567           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise force-pushed the dev.ej/full-pytest branch from ec2e231 to d636890 Compare April 29, 2026 19:53
Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@joanise joanise merged commit 1b85524 into main May 1, 2026
13 checks passed
@joanise joanise deleted the dev.ej/full-pytest branch May 1, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants