Conversation
1) they don't actually work with pytest, so we had disabled them 2) at this point they're always disabled since we always import pytest 3) the problem they address is handled correctly by pytest, since unlike unittest it captures all output and only shows it on demand and/or on error.
This was referenced Apr 29, 2026
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 47 47
Lines 4203 4203
Branches 615 615
=======================================
Hits 3506 3506
Misses 567 567
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ec2e231 to
d636890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Make pytest the way we run tests in every circumstance.
At the same time, I removed
silence_c_str{err,out}because they do nothing when using pytest.How to test?
pytesteveryvoice/run_tests.pydoes effectively the same, but it still has suites, and--describeConfidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/wav2vec2aligner#29
EveryVoiceTTS/FastSpeech2_lightning#138