-
Notifications
You must be signed in to change notification settings - Fork 400
chore: remove experimental_propagate_process_tags_enabled from runtime metrics initialize #5465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wantsui
wants to merge
18
commits into
master
Choose a base branch
from
refactor-runtime-metrics-chore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3246736
Set the default of DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED to …
wantsui 2508130
Remove the process tags from the remote client payload since it is no…
wantsui 41c5ecc
Adjust DBM tests for the new default true setting
wantsui cb9f2dc
Adjust telemetry payload in tests due to the new default
wantsui b9b20f4
Fix another dbm test for the true default for process tag
wantsui 3e5641d
Add the process tags payload to the remote config payload in tests si…
wantsui 29b5fd7
Change supported-configurations.json from A to B
wantsui 53a6b4a
Remove fallback for runtime metrics and update runtime metrics tests …
wantsui 8e5464e
Simplify the settings_spec test per review
wantsui 1831a5b
Bring back tags and process_tags when testing remote client_spec
wantsui 427cd21
Adjust telemetry tests to start off with the assumption that process …
wantsui f8c3323
Update spec/datadog/core/workers/runtime_metrics_spec.rb
wantsui 9a8649b
Refactor runtime_metrics_spec.rb to use receive syntax
wantsui ecd5cb5
Add an internal alias for propagate_process_tags_enabled that doesn't…
wantsui e854814
Add missing test
wantsui 49efe37
Add back the experimental designation so it can be deleted later
wantsui 8e27c3e
Merge branch 'master' into enable-process-tags
wantsui f362eb8
Remove the unneeded experimental_propagate_process_tags_enabled durin…
wantsui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, my suggestion was to get rid of this whole default, not just passing the flag to
Core::Runtime::Metrics.new👀There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I'll keep refactoring (and now I'm glad I split this out into its own PR).