chore: remove experimental_propagate_process_tags_enabled from runtime metrics initialize#5465
chore: remove experimental_propagate_process_tags_enabled from runtime metrics initialize#5465
Conversation
…true and adjust tests
…t needed for the test
…nce it defaults to true now
…tags are disabled to avoid mixing testing concerns
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
… include experimental and adjust specs to match
wantsui
added
the
AI Generated
| Core::Runtime::Metrics.new( | ||
| logger: options[:logger], | ||
| telemetry: telemetry, | ||
| experimental_propagate_process_tags_enabled: options.fetch(:propagate_process_tags_enabled) do | ||
| options.fetch(:experimental_propagate_process_tags_enabled) | ||
| end | ||
| telemetry: telemetry |
There was a problem hiding this comment.
Wait, my suggestion was to get rid of this whole default, not just passing the flag to Core::Runtime::Metrics.new 👀
There was a problem hiding this comment.
🤔 I'll keep refactoring (and now I'm glad I split this out into its own PR).
There was a problem hiding this comment.
Is this change intended for this PR?
There was a problem hiding this comment.
No but it's weird it's showing up here when the PR where this branch split from has it already: https://github.com/DataDog/dd-trace-rb/pull/5432/changes#diff-aad6bdf47cba29fa1524d045aeff4a4f02d53882030f72b3669fda0bc969b8c7
I'll dig into it!
There was a problem hiding this comment.
It's because this PR is/was stacked atop #5432 but that got squash-merged to master, so git doesn't recognize they are the same.
So this needs a rebase atop master. I suspect won't detect the commits as the same/empty, so you may need to manually do an interactive rebase and remove those commits from the list.
(There's a non-zero chance that claude also can do it for you if you give him the info from above :P )
3 participants
What does this PR do?
Follows up on #5432 (comment) and gets rid of the propagate_process_tags_enabled usage in runtime_metrics.rb
Motivation:
Change log entry
No.
Additional Notes:
How to test the change?