Skip to content

chore(ci): update slos #17205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faydef wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(ci): update slos #17205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
892f982
update slos
faydef Mar 31, 2026
30506c4
Merge branch 'main' into fayssal/update-slos
brettlangdon Mar 31, 2026
323a7fc
add slo generation docs
faydef Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions .gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
# Example of measurements can be seen here: https://benchmarking.us1.prod.dog/benchmarks?benchmarkGroupPipelineId=66629462&benchmarkGroupSha=16054515e292a66c5eaf79b9ea62df6f348cd67e&page=1&ciJobDateStart=1746309551994&ciJobDateEnd=1748901551994&benchmarkId=14167634
# Auto-generated SLO Thresholds
# Generated: 2026-03-31
#
# Generation Strategy: tight
# Formula: CI_bound / (1 ± T) (T = 5.0%)
#
# SLO Checking:
# - BREACH: 90% CI boundary crosses threshold
# - WARNING: 90% CI boundary crosses warning_threshold (constant)
#
# DO NOT EDIT MANUALLY - Regenerate using:
# benchmark_analyzer generate slos --help
Copy link
Copy Markdown
Member

@brettlangdon brettlangdon Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need more details here or in some docs/ somewhere, how do we install/use this tool?

Copy link
Copy Markdown
Author

@faydef faydef Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!
Here is a link to the docs I will add it to the slo file itself!


# Thresholds set based on guidance in https://datadoghq.atlassian.net/wiki/spaces/APMINT/pages/5070193198/How+to+set+up+pre-release+performance+quality+gates#How-to-choose-thresholds-for-pre-release-gates%3F
# link to documentation on autogenerated thresholds https://github.com/DataDog/relenv-benchmark-analyzer/blob/main/README.md#generate-slo-thresholds

experiments:
- name: Run SLO breach check
Expand All @@ -24,7 +35,7 @@ experiments:
- agg_http_req_duration_p95 < 100 ms
- name: high_load/tracing-rc-enabled-telemetry-enabled
thresholds:
- throughput > 45.0 op/s
- throughput > 51.625 op/s
- agg_http_req_duration_p99 < 100 ms
# Appsec
- name: normal_operation/appsec-enabled-iast-disabled-ep-disabled
Expand All @@ -46,7 +57,7 @@ experiments:
- rss < 1040 MB
- name: high_load/tracing-profiling-enabled
thresholds:
- throughput > 30.0 op/s
- throughput > 49.938 op/s
- agg_http_req_duration_p99 < 110 ms
# Multi-product
- name: normal_operation/vuln-appsec-disabled-iast-enabled-ep-disabled-profiling-enabled
Expand Down
Loading