Open
Conversation
| # - WARNING: 90% CI boundary crosses warning_threshold (constant) | ||
| # | ||
| # DO NOT EDIT MANUALLY - Regenerate using: | ||
| # benchmark_analyzer generate slos --help |
Member
There was a problem hiding this comment.
we might need more details here or in some docs/ somewhere, how do we install/use this tool?
Author
There was a problem hiding this comment.
Sure thing!
Here is a link to the docs I will add it to the slo file itself!
brettlangdon
approved these changes
Mar 31, 2026
This comment has been minimized.
This comment has been minimized.
Codeowners resolved as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates SLOs that were identified as optimizable during OE review in Febuary, 2026. PR sets SLOs at ca. 10% higher than SLIs collected from actual run, to make sure gates are not flaky, but still able to catch regression if it happens.
These SLOs were set too loosely and thus would not catch potential regressions.
Example
Testing
Risks
Additional Notes