Skip to content

fix(ci_visibility): handle PYTEST_ADDOPTS for enabling code coverage collection [backport 3.9] #13828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport b0c1496 from #13820 to 3.9.

This fix resolves an issue where code coverage would not be enabled if ddtrace was enabled via the PYTEST_ADDOPTS environment variable.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

…collection (#13820)

This fix resolves an issue where code coverage would not be enabled if
ddtrace was enabled via the ``PYTEST_ADDOPTS`` environment variable.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit b0c1496)
@github-actions github-actions bot requested review from a team as code owners June 30, 2025 18:01
@vitor-de-araujo vitor-de-araujo enabled auto-merge (squash) June 30, 2025 18:05
auto-merge was automatically disabled June 30, 2025 18:05

Pull request was closed

Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/ci_visibility-fix-pytest-addopts-early-init-74fb4e207dee18e4.yaml  @DataDog/apm-python
tests/contrib/pytest/test_pytest_early_config.py                        @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_plugin_v1.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_utils.py                               @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest.py                                     @DataDog/ci-app-libraries

Copy link
Contributor Author

github-actions bot commented Jun 30, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 3 ms.

The average import time from base is: 277 ± 3 ms.

The import time difference between this PR and base is: -2.4 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.010 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.331 ms (0.48%)
ddtrace.bootstrap.preload 1.331 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.638 ms (0.23%)
ddtrace 0.678 ms (0.25%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 30, 2025

Benchmarks

Benchmark execution time: 2025-07-01 14:22:14

Comparing candidate commit 1b97eac in PR branch backport-13820-to-3.9 with baseline commit ee1aabe in branch 3.9.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 549 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+550.826ns; +784.565ns] or [+13.371%; +19.045%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+413.449ns; +500.018ns] or [+12.053%; +14.577%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+527.738ns; +577.794ns] or [+14.275%; +15.629%]

scenario:iastaspectsospath-ospathsplitext_aspect

  • 🟥 execution_time [+712.372ns; +816.337ns] or [+15.658%; +17.943%]

@vitor-de-araujo vitor-de-araujo enabled auto-merge (squash) July 1, 2025 13:45
@vitor-de-araujo vitor-de-araujo merged commit 9463448 into 3.9 Jul 1, 2025
387 of 388 checks passed
@vitor-de-araujo vitor-de-araujo deleted the backport-13820-to-3.9 branch July 1, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants