-
Notifications
You must be signed in to change notification settings - Fork 443
chore: update span buffer and min flush count #13817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 277 ± 2 ms. The average import time from base is: 281 ± 5 ms. The import time difference between this PR and base is: -4.6 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-30 14:11:41 Comparing candidate commit 57a0e21 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 530 metrics, 3 unstable metrics. scenario:iastaspects-format_map_aspect
|
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
fixes: | ||
- | | ||
- Increase ``DD_TRACE_BUFFER_SIZE_BYTES`` default value to 30MB to avoid potential OOMs under heavy load situations. | ||
- Decrease ``DD_TRACE_PARTIAL_FLUSH_MIN_SPANS`` to 200. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
increase
DD_TRACE_WRITER_BUFFER_SIZE_BYTES
to 30MB and decreaseDD_TRACE_PARTIAL_FLUSH_MIN_SPANS
to 200 spans.Also update the documentation, which actually had a wrong value.
Checklist
Reviewer Checklist