Bunch of crafting recipe culling#918
Bunch of crafting recipe culling#918FalloutFalcon wants to merge 9 commits intoDarkPack13:masterfrom
Conversation
| var/datum/st_stat/recipe_skill = recipe.skill_required_for_use | ||
| var/level_required = recipe.skill_dots_minimum | ||
| if(recipe_skill) | ||
| if(human_crafter.st_get_stat(recipe_skill) < level_required) | ||
| return ", you dont know how to craft! You need at least [level_required] in [recipe_skill::name]!" | ||
| recipe_time = recipe_time / max(human_crafter.st_get_stat(recipe_skill), 1) |
There was a problem hiding this comment.
so i notice the config check is gone but now all crafting recipes have skill dots minimum = 0? From what I can tell this allows people with crafts zero to craft like, the most simple recipes like bouquets? what about arcane/necro/abyss tomes?
There was a problem hiding this comment.
yea. I think it makes more sense as a default, the same way i did for machines, where there is just WAY to much variance in task complexity to broadly say your incapable of making it without actually taking a second to think through each recipes complexity.
The tomes seem like a good candidate to make them an occult skill req instead? thoughts on the level? 1 seems appropriate.
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
| result = /obj/item/ritual_tome/abyss | ||
| category = CAT_MISC | ||
| skill_required_for_use = STAT_OCCULT | ||
| skill_dots_minimum = 1 |
There was a problem hiding this comment.
| skill_dots_minimum = 1 | |
| skill_dots_minimum = 4 |
to reflect the fact that not every obtenebration user is an abyss mystic and that abyss mysticism is not well known among lasombra
There was a problem hiding this comment.
I ultimately think its not super required. Casting rituals requires a successful Intelligence + Occult roll, for which the difficulty equals 3 + the level of the ritual (maximum 9)
I think we should mostly lock stuff, per ritual, and with the roll to preform it itself. Because the book is FUNCTIONALLY required for ritual casting, we shouldn't lock people out of it for characters that can otherwise preform said rituals consistently.
There is an argument that they should just spawn with it anyway as we give it to the jobs. And then this just acts as a way to make replacements.
There was a problem hiding this comment.
Someone did fetch me this section however. pg 271 of VtM DA V20.
There was a problem hiding this comment.
looks like 3 then? ive heard that abyss mysticism is not widely held among Lasombra - thus i would imagine it has a higher barrier to entry than other things.
| skill_required_for_use = STAT_OCCULT | ||
| skill_dots_minimum = 1 |
There was a problem hiding this comment.
| skill_required_for_use = STAT_OCCULT | |
| skill_dots_minimum = 1 | |
| skill_dots_minimum = 2 |
necromancy is not as widespread and standardized as thaumaturgy
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
cool! lmk what u think of my suggestions
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
2 participants
About The Pull Request
Cuts a bunch of recipes from TG that dont REALLY seem like they fit.
For alot of the weird makeshift items, i added some code so we can have varied skill requirments and locked them behind it. I even readd a few that now make sense with this limitation.
This includes that big ballista which apparently is being crafted in TFN, i understand why, its funny/cool as shit but like.. hrm. that is not something that should be pulled out frequently
new skill locks; crafting unless i specifcy
Why It's Good For The Game
TG "cruft" for us. skill expression...
Changelog
🆑
del: Removes a few more TG crafting recipes
balance: Gives varried skill requirments to a buncha recipes (most are set to only need 0, a ton of the funny ones need 1-5)
/:cl: