Skip to content

JCF: DUNE-DAQ/.github#13: a commit for a commit's sake#118

Closed
jcfreeman2 wants to merge 3 commits intodevelopfrom
johnfreeman/github_issue13_test
Closed

JCF: DUNE-DAQ/.github#13: a commit for a commit's sake#118
jcfreeman2 wants to merge 3 commits intodevelopfrom
johnfreeman/github_issue13_test

Conversation

@jcfreeman2
Copy link
Contributor

DO NOT MERGE THIS. This PR is being used to test my work addressing DUNE-DAQ/.github#13

Description

If full decription and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2
Copy link
Contributor Author

n.b. The failed single repo CI workflow (https://github.com/DUNE-DAQ/ipm/actions/runs/21679076806) is expected, and it's exactly the problem I'm trying to address with the johnfreeman/issue13_fix_dbe_CI_handling branch of the .github repo.

John Freeman added 2 commits February 4, 2026 10:23
…w on the feature branch I've been working on for this .github Issue mentioned at the head of this commit comment
@jcfreeman2 jcfreeman2 closed this Feb 5, 2026
@jcfreeman2 jcfreeman2 deleted the johnfreeman/github_issue13_test branch February 5, 2026 15:44
@jcfreeman2
Copy link
Contributor Author

Automatically closed the issue by deleting the branch; this was only being used to test GitHub Actions themselves, not the code in ipm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant