Skip to content

Added support for checking recommended computer resources in integtests#143

Open
bieryAtFnal wants to merge 3 commits intodevelopfrom
kbiery/recommended_resource_checking
Open

Added support for checking recommended computer resources in integtests#143
bieryAtFnal wants to merge 3 commits intodevelopfrom
kbiery/recommended_resource_checking

Conversation

@bieryAtFnal
Copy link
Contributor

Description

In DUNE-DAQ/daqsystemtest#292, Eric asked about the possibility of separately checking required computer resources in an integtest compared to recommended computer resources.

This PR has changes to add the support for recommended computer resources to the existing support for required ones.

These changes are now needed to test the ones in DUNE-DAQ/daqsystemtest#292.

Type of change

  • Optimization (non-breaking change that improves code/performance)

Testing checklist

  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I might be requesting a command-line flag to bypass these checks entirely, since they don't play very well with my virtual machine's dynamic memory management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants