Added checking of computer resources in integtests#292
Open
bieryAtFnal wants to merge 13 commits intodevelopfrom
Open
Added checking of computer resources in integtests#292bieryAtFnal wants to merge 13 commits intodevelopfrom
bieryAtFnal wants to merge 13 commits intodevelopfrom
Conversation
…rce checking before running tests.
…tirun_test.py and long_window_readout_test.py.
…ng_window_readout_test.py.
…ter_resources_in_integtests
…ter_resources_in_integtests
… run_nanorc0 string from config names in the banners of tests that needed that.
… there are insufficient computer resources.
…ter_resources_in_integtests
…sufficient computer resources are available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To help avoid confusion when the
daqsystemtestintegtests are run on computers that may or may not have sufficient resources (CPUs, memory, disk space), I have added checks on such resources to all of the integtests in this repo. When a computer does not have sufficient resources, the integtest is skipped. (This is accomplished by having thepytest"tests" skipped using thepytest.skip()functionality.)To test these changes, I have run the modified integtests (typically with
dbt-build --integtest) on several computers, some of which have lots of resources, and some of which don't. I considered the tests successful when either they ran cleanly or they were skipped because of insufficient resources.It would be great for reviewers to also run these modified tests on different computers and verify similar behavior (consistent success or skipping).
Type of change
Testing checklist
pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)Further checks