Unify order in various table outputs#766
Conversation
|
Hi @PawelPlesniak @MRiganSUSX, this is the quick PR thats attached to #764. Code is pretty much ready to go in, but a couple of points to discuss:
|
|
I have done a thing and tacked on fixing #706 in this one, hope thats fine. Can you both review it since this is something that is useful for ops etc? |
Question and comment feedback
I tested the difference between develop and this branch's
When running tests, however, this is not implemented - can we correct this? I will continue the review after lunch |
|
Hi @emmuhamm, I have some comments / suggestions: |
|
One more suggestion (this is to @PawelPlesniak as well). Could we change the 'title' of the log block to the name of the app instead of the uuid (uuid requires additional matching for the person using this).
|
|
Hi @MRiganSUSX, thanks for the review and suggestions!
Can do! Just to confirm, you want to have the 'title' be in both the start and the end? |
Yes, I think that makes sense. |
It would also be good to go from UUID of the process to the process name |
|
Summary of requested changes
|
Perhaps later indeed
Sorry for the lack of clarity earlier. Where you have |
|
Ah yes apologies, I thought the name would have been automatically correct and didnt check too closely. b5e446e should fix it, and I made it so that it defaults to the process name, then UUID if name isnt found, then empty if even the UUID isn't found (see updated desc). To fix this, I had to make changes in both the ssh and k8s pm implementation. I've tested both to work but since I'm not the most familiar with k8s its worth a look at this commit |
|
I made a small commit to change the following to Other than that, I am very happy with the logic, there is now a consistent order, and |
|
For completion, what the output of |
|
Am awaitng release of change request from @MRiganSUSX, will merge once complete |
Changes have been implemented; this github features blocking merge







Description
Change table outputs
Fixes #764
This is a small and quick PR that fixes how the tables are ordered in the table outputs.
See attached output
Better handling of logs command
Fixes #706
Updated the logs command to properly raise the
BadQueryand correctly propagate it through gRPC so it can be caught by the process_manager_driver. This modifies the log outputs in the terminal as necessary.This lets us keep the line when the logs do exist (useful as theres many lines that will be printed out, and helps keeps the tty distinct. I also like the line :)), but also more traceable logs when something goes wrong hopefully.
Also if for whatever reason the name cant be found, it will then go to the UUID. In the unlikely event that also isnt returned, the display string will be empty.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))