Remaining dedicated grpc messages refactor#736
Open
jamesturner246 wants to merge 9 commits intodevelopfrom
Open
Remaining dedicated grpc messages refactor#736jamesturner246 wants to merge 9 commits intodevelopfrom
jamesturner246 wants to merge 9 commits intodevelopfrom
Conversation
9 tasks
Collaborator
|
Hi James, thank you for this PR, having commands addressed correctly is great! Few requests Could we similarly have a warning log message of when running the following? Can we also have similar log messages for the following I will also define user stories on how we define error states - manually setting an application into error and attempting to get out of it using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #686.
Refactors the remaining controller fns:
take_control,submit_control,who_is_in_control,to_error, and gives them their own message types.Also remove a whole lot of the older code.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))