Skip to content

Remaining dedicated grpc messages refactor#736

Open
jamesturner246 wants to merge 9 commits intodevelopfrom
jamesturner246/remaining_grpc_refactor
Open

Remaining dedicated grpc messages refactor#736
jamesturner246 wants to merge 9 commits intodevelopfrom
jamesturner246/remaining_grpc_refactor

Conversation

@jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented Dec 5, 2025

Description

Resolves #686.

Refactors the remaining controller fns: take_control, submit_control, who_is_in_control, to_error, and gives them their own message types.

Also remove a whole lot of the older code.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jamesturner246 jamesturner246 marked this pull request as ready for review December 8, 2025 12:19
@PawelPlesniak PawelPlesniak added the enhancement New feature or request label Jan 22, 2026
@PawelPlesniak
Copy link
Collaborator

Hi James, thank you for this PR, having commands addressed correctly is great! Few requests
When running surrender-control, could we have an info log message of

User <username> has surrendered control of session <session id>

Could we similarly have a warning log message of

User <username> is not in control of session <session id>

when running the following?

drunc-unified-shell > surrender-control
drunc-unified-shell > surrender-control
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
        status = StatusCode.INTERNAL
        details = "Exception deserializing response!"
        debug_error_string = "None"
>

Can we also have similar log messages for the following

drunc-unified-shell > take-control
drunc-unified-shell > take-control

I will also define user stories on how we define error states - manually setting an application into error and attempting to get out of it using recompute-status currently does not remove the error state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: dedicated message types for remaining controller RPCs

2 participants