Skip to content

Remaining dedicated grpc messages schemas#82

Open
jamesturner246 wants to merge 6 commits intodevelopfrom
jamesturner246/remaining_grpc_refactor
Open

Remaining dedicated grpc messages schemas#82
jamesturner246 wants to merge 6 commits intodevelopfrom
jamesturner246/remaining_grpc_refactor

Conversation

@jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented Dec 5, 2025

Description

Resolves #77.

Sister PR to DUNE-DAQ/drunc#736.

Also recompile schemas, due to grpc version bump.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jamesturner246 jamesturner246 marked this pull request as ready for review December 8, 2025 12:21
@jamesturner246 jamesturner246 changed the title Dedicated grpc messages for take_control. Remaining dedicated grpc messages schemas Dec 8, 2025
@PawelPlesniak PawelPlesniak added the enhancement New feature or request label Jan 22, 2026
@PawelPlesniak
Copy link
Contributor

For this PR, I needed to recompile the schema to run this, so I am including the compiled results in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Dedicated protobuf schemas for RPCs in controller

2 participants