Replaced the relative path to the daqsystemtest/example-configs.data.xml file...#29
Merged
bieryAtFnal merged 2 commits intodevelopfrom Jan 26, 2026
Merged
Conversation
added 2 commits
January 22, 2026 10:35
…xml file in the integration test with a path based on the DAQSYSTEMTEST_SHARE environmental variable.
…EST_SHARE env var in the location of the example-configs.data.xml file.
denizergonul
approved these changes
Jan 23, 2026
Contributor
denizergonul
left a comment
denizergonul
left a comment
There was a problem hiding this comment.
Confirmed that if there's daqsystemtest in the local area, it is used; otherwise, cvmfs is used. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in the integtest with a path based on the DAQSYSTEMTEST_SHARE environmental variable.
Description
I've noticed that we can't run the
crtmodules/integtest/crt_reader_testfrom a base release. But, it can be run from a local software area.John pointed out that the location of the base configuration file was specified in the integtest using a relative path, which may or may not work outside of a local software area.
The change in this PR is to make use of the DAQSYSTEMTEST_SHARE env var instead of a relative path.
A good test of this change is to confirm that the integtest still works when the package is included in a local software area. The true test of the change will come when we get a nightly build with this change included.
Type of change
Testing checklist
pytest -s crt_reader_test.py)Further checks