Johnfreeman/issue517 autofill dunedaq db path#524
Merged
jcfreeman2 merged 4 commits intodevelopfrom Feb 5, 2026
Merged
Conversation
added 4 commits
February 2, 2026 10:17
…auto-deduce whether a given package needs to be added to DUNEDAQ_DB_PATH
…pite not generating code from OKS XML files, it still needs DUNEDAQ_DB_PATH populated because of its ATLAS-era unit tests
…H if it contains an OKS schema or data file
Collaborator
|
I think this all looks good, but I want to check something before approving. If I create a local build area based off |
Collaborator
Author
|
Good cross check. To explain:
|
Collaborator
|
Thanks, that helps. With that, I approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is very much in the spirit of #352. In a nutshell, rather than Software Coordination needing to manually add a repo's addition to
DUNEDAQ_DB_PATHto the repo'spackage.pyfile,make-release-repo.pyhas been updated to check for OKS data and schema files in a repo and, should they exist, to updatepackage.pyaccordingly by substituting theXDBPATHXtoken. Note thatDDPFD_DEV_260204_A9is built using this feature branch of daq-release and that it recreates the performance of the extended integration tests (https://github.com/DUNE-DAQ/daq-release/actions/runs/21680817046) and the classic integration tests (https://github.com/DUNE-DAQ/daq-release/actions/runs/21686107769).