Align codebase with DUNE-DAQ C++ Style Guide

[Copilot]

Description

Style compliance review identified violations of the DUNE-DAQ C++ Style Guide. Changes modernize code and fix naming conventions without altering functionality.

Changes Made

Enumerator naming (§2.7)

• ValidationReport::Severity: converted to enum class with k prefix
  • Fatal → kFatal, Error → kError, Warning → kWarning, etc.
• Anonymous enum in ConfigurationManager.cpp: TLVL_SESSION → kTlvlSession, etc. REVERTED - TLVL constants kept in original all-caps format per maintainer feedback

Type declarations (§7.7)

• DAQModuleManager.hpp: replaced C-style typedef with using declaration

Documentation

• Corrected typos in file headers: "implementataion" → "implementation", "convinience" → "convenience", "mdoule" → "module"

Example of enum changes:

// Before
enum Severity { Fatal, Error, Warning, Info, Ignored };
ValidationReport report(ValidationReport::Severity::Fatal, ...);

// After
enum class Severity { kFatal, kError, kWarning, kInfo, kIgnored };
ValidationReport report(ValidationReport::Severity::kFatal, ...);

Note: Changes to ConfigurationManager.cpp enum constants were reverted to maintain the original TLVL naming convention (TLVL_SESSION, TLVL_APP, etc.) while keeping the necessary compatibility update for ValidationReport::Severity enum values.

Type of change

• Optimization (non-breaking change that improves code/performance)

Testing checklist

• Unit tests pass (e.g. dbt-build --unittest)
• Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
• Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
• Python tests pass if applicable (e.g. python -m pytest)
• Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Automated code review and security scan completed with no issues found.

Further checks

• Code is commented where needed, particularly in hard-to-understand areas
• Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
• If applicable, new tests have been added or an issue has been opened to tackle that in the future.

Original prompt

Please review this code using the DUNE-DAQ/styleguide

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[eflumerf]

@copilot revert the changes to ConfigurationManager.cpp

[Copilot]

@copilot revert the changes to ConfigurationManager.cpp

Reverted the enum naming changes to ConfigurationManager.cpp. The TLVL constants now use their original all-caps naming (TLVL_SESSION, TLVL_APP, etc.). Only kept the necessary update to ValidationReport::Severity::kFatal for compatibility with the enum class change. (4ddeb76)