-
Notifications
You must be signed in to change notification settings - Fork 57
Add Visual Studio as an alternative to edit DNN Docs articles. Additionally… #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 7 image files where renamed, was it verified that they were not used by other articles? If not, I would prefer to avoid the renaming.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I checked and just now rechecked if there were any references in DNN Docs to the following files:
3 OTHER files only are mentioned in the manifest.json. To my knowledge that means they are not actively used. Would you like me to create a pull request deleting those?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it is not related to this change, I would leave the files and place and optionally do another PR if you want to delete unused files.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is and it isn't related to this change. I've added a couple of screenshots in the DNN Doc articles in which these existing screenshots are used as well. And in doing so aligned the naming of the files (using the original file names), thus clustering them. See screenshot underneath.
Would you mind having the name changes included? I'm more than happy to do some extra checks. |

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why 6 & 7 & 8 here? If I understand correctly its is because 1-10 are different if using VisualStudio or not, but then 11 is common. If so maybe it should be broken down as I find that confusiong...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Prerequisites Steps and steps 11 and 12 are identical for Git and Visual Studio. The first 10 steps are conceptually the same, but in what to do (in Git versus Visual Studio) different. That apparently is not clear enough. I will split up Git and Visual Studio completely.
I'm quite new to Git. Shall I checkout the same branch the pull request is based on and push to it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can push additional commits to this branch which will update this Pull Request