Add Visual Studio as an alternative to edit DNN Docs articles. Additionally…#793
Add Visual Studio as an alternative to edit DNN Docs articles. Additionally…#793GVskl wants to merge 2 commits into
Conversation
…d a bit more clarity on the repos; names and where they are located: local or remote (on Github). Thus flattening the learning curve.
|  | ||
| For more elaborate instructions on how to create a new branch in Visual Studio see https://learn.microsoft.com/en-us/visualstudio/version-control/git-create-branch?view=visualstudio. | ||
| 5. Make your edits | ||
| 6. & 7. & 8. Preview your work and files locally using the 'Git Changes' tab in Visual Studio. |
There was a problem hiding this comment.
Any reason why 6 & 7 & 8 here? If I understand correctly its is because 1-10 are different if using VisualStudio or not, but then 11 is common. If so maybe it should be broken down as I find that confusiong...
There was a problem hiding this comment.
The Prerequisites Steps and steps 11 and 12 are identical for Git and Visual Studio. The first 10 steps are conceptually the same, but in what to do (in Git versus Visual Studio) different. That apparently is not clear enough. I will split up Git and Visual Studio completely.
I'm quite new to Git. Shall I checkout the same branch the pull request is based on and push to it again?
There was a problem hiding this comment.
Yes you can push additional commits to this branch which will update this Pull Request
There was a problem hiding this comment.
7 image files where renamed, was it verified that they were not used by other articles? If not, I would prefer to avoid the renaming.
There was a problem hiding this comment.
I checked and just now rechecked if there were any references in DNN Docs to the following files:
- git-compare-and-pull-request-screenshot.jpg
- edit-article-in-browser.jpg
- fork-screenshot.jpg
- git-issue-screenshot.jpg
- in-browser-pull-request.gif
- In-Browser-Pull-Request-2.gif
- git-pull-request-resolves-screenshot.jpg
I couldn't find any.
I changed the file names to OOP-like naming because it clusters related files which reduces the chance of duplicating files and keeping files that are not used anymore.
3 OTHER files only are mentioned in the manifest.json. To my knowledge that means they are not actively used. Would you like me to create a pull request deleting those?
There was a problem hiding this comment.
Since it is not related to this change, I would leave the files and place and optionally do another PR if you want to delete unused files.
2 participants
…add a bit more clarity on the repos; names and where they are located: local or remote (on Github). Thus flattening the learning curve a bit.