Skip to content

Fix Create Item Filters to allow vanilla use behavior to work #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FactaviCk wants to merge 4 commits into
base: mc1.21.1/dev
Choose a base branch
from
+4 −1
Open

Fix Create Item Filters to allow vanilla use behavior to work #10337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0f6359
edible filters! but only when spawned in with food components... :)
May 10, 2026
6b33c6b
cleanup with call to super.use
May 10, 2026
708c3db
remove unused import
May 10, 2026
3b968e7
prevent abuse of using_converts_to food component with schematics
May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/simibubi/create/content/logistics/filter/FilterItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ public InteractionResultHolder<ItemStack> use(Level world, Player player, Intera
});
return InteractionResultHolder.success(heldItem);
}
return InteractionResultHolder.pass(heldItem);
else {
Comment thread
FactaviCk marked this conversation as resolved.
return super.use(world, player, hand);
}
}

@Override
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/simibubi/create/content/logistics/filter/FilterItemStack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public static FilterItemStack empty() {
private static void trimFilterComponents(ItemStack filter) {
filter.remove(DataComponents.ENCHANTMENTS);
filter.remove(DataComponents.ATTRIBUTE_MODIFIERS);
filter.remove(DataComponents.FOOD); // Prevent schematics from abusing the food using_converts_to component
}

public boolean isEmpty() {
Expand Down