Skip to content

Fix Create Item Filters to allow vanilla use behavior to work#10337

Open
FactaviCk wants to merge 4 commits into
Creators-of-Create:mc1.21.1/devfrom
FactaviCk:mc1.21.1/dev
Open

Fix Create Item Filters to allow vanilla use behavior to work#10337
FactaviCk wants to merge 4 commits into
Creators-of-Create:mc1.21.1/devfrom
FactaviCk:mc1.21.1/dev

Conversation

@FactaviCk
Copy link
Copy Markdown

@FactaviCk FactaviCk commented May 10, 2026

Fixes #10335

If the player is sneaking, instead of immediately passing, calls super.use().

This also fixes any behavior modifications of Item.use provided by mixins from other mods.

Schematics will sanitize food components when setting filters in order to prevent players from abusing #10373 to obtain arbitrary items via schematic nbt preservation exploit.

@FactaviCk
Copy link
Copy Markdown
Author

suggested tags: pr flag: simple, pr type: fix

@VoidLeech VoidLeech added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels May 10, 2026
Comment thread src/main/java/com/simibubi/create/content/logistics/filter/FilterItem.java Outdated
@FactaviCk
Copy link
Copy Markdown
Author

6.0.11?

@VoidLeech
Copy link
Copy Markdown
Collaborator

That’s up to the maintainers. They are all busy people who work on the mod in their free time, so there’s no timeline for when this gets reviewed for a possible merge.

In light of #10373 (filters similarly print with most components intact) this should adjust

private static void trimFilterComponents(ItemStack filter) {

@FactaviCk FactaviCk changed the title Fix Item Filters to allow minecraft:food item component to work Fix Create Item Filters to allow vanilla use behavior to work May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr flag: simple PR has minimal changes pr type: fix PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Many create filter items do not handle food nbt properly

2 participants