Adding a Verilog example using PicoSoC #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatecat
force-pushed
the
add-verilog-example
branch
3 times, most recently
from
b426930 to
f9a4d9c
Compare
|
I think it belongs here. Defining the iopins here is better as well. Let's not add a makefile - it was removed from the others. |
Seems like it wasn't? e.g. https://github.com/ChipFlow/chipflow-examples/blob/main/mcu_soc/Makefile |
gatecat
force-pushed
the
add-verilog-example
branch
from
f9a4d9c to
7d0876e
Compare
gatecat
force-pushed
the
add-verilog-example
branch
3 times, most recently
from
91ced06 to
8e2c516
Compare
robtaylor
force-pushed
the
add-verilog-example
branch
2 times, most recently
from
91ced06 to
210cfbd
Compare
gatecat
force-pushed
the
add-verilog-example
branch
from
210cfbd to
e7dde63
Compare
gatecat
force-pushed
the
add-verilog-example
branch
from
e7dde63 to
e64bf92
Compare
|
Hopefully once ChipFlow/chipflow-lib#129 is in this is ready to go! |
Signed-off-by: gatecat <[email protected]>
gatecat
force-pushed
the
add-verilog-example
branch
from
e64bf92 to
90cb442
Compare
robtaylor
reviewed
Jul 14, 2025
Comment on lines
+50
to
+63
| base = os.path.dirname(__file__) | ||
|
|
||
| verilog_sources = [ | ||
| f"{base}/picosoc_asic_top.v", | ||
| f"{base}/picorv32/picosoc/spimemio.v", | ||
| f"{base}/picorv32/picosoc/simpleuart.v", | ||
| f"{base}/picorv32/picosoc/picosoc.v", | ||
| f"{base}/picorv32/picorv32.v", | ||
| ] | ||
|
|
||
| for verilog_file in verilog_sources: | ||
| with open(verilog_file, 'r') as f: | ||
| platform.add_file(verilog_file, f) | ||
|
|
There was a problem hiding this comment.
Just wondering, could we have a chipflow.toml section to include external code, or maybe use a seperate toml file for defining the import?
Comment on lines
+65
to
+93
| # Clock and reset | ||
| i_clk=ClockSignal(), | ||
| i_resetn=~ResetSignal(), | ||
|
|
||
| # UART | ||
| o_ser_tx=self.uart_0.tx.o, | ||
| i_ser_rx=self.uart_0.rx.i, | ||
|
|
||
| # SPI flash | ||
| o_flash_csb=self.flash.csn.o, | ||
| o_flash_clk=self.flash.clk.o, | ||
|
|
||
| o_flash_io0_oe=self.flash.d.oe[0], | ||
| o_flash_io1_oe=self.flash.d.oe[1], | ||
| o_flash_io2_oe=self.flash.d.oe[2], | ||
| o_flash_io3_oe=self.flash.d.oe[3], | ||
|
|
||
| o_flash_io0_do=self.flash.d.o[0], | ||
| o_flash_io1_do=self.flash.d.o[1], | ||
| o_flash_io2_do=self.flash.d.o[2], | ||
| o_flash_io3_do=self.flash.d.o[3], | ||
|
|
||
| i_flash_io0_di=self.flash.d.i[0], | ||
| i_flash_io1_di=self.flash.d.i[1], | ||
| i_flash_io2_di=self.flash.d.i[2], | ||
| i_flash_io3_di=self.flash.d.i[3], | ||
|
|
||
| # LEDs | ||
| o_leds=self.gpio_0.gpio.o |
There was a problem hiding this comment.
Again, might be something worth putting in a toml description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a don't-merge for now, while I figure out while the cxxrtl agent is hitting an
terminating due to uncaught exception of type std::out_of_range: unordered_map::at: key not foundwithout the workaround added to it...Everything else is ready for review, although I have a couple of questions: