Improve LWJGL wrong version error message

common/src/boot/java/net/caffeinemc/mods/sodium/client/compatibility/checks/PreLaunchChecks.java

@@ -2,12 +2,21 @@
 
 import net.caffeinemc.mods.sodium.client.platform.PlatformHelper;
 import org.lwjgl.Version;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.net.URL;
+import java.security.CodeSource;
+import java.security.ProtectionDomain;
+import java.util.Locale;
 
 /**
  * Performs OpenGL driver validation before the game creates an OpenGL context. This runs during the earliest possible
  * opportunity at game startup, and uses a custom hardware prober to search for problematic drivers.
  */
 public class PreLaunchChecks {
+    private static final Logger LOGGER = LoggerFactory.getLogger("Sodium-PreLaunchChecks");
+
     // These version constants are inlined at compile time.
     private static final String REQUIRED_LWJGL_VERSION =
             Version.VERSION_MAJOR + "." + Version.VERSION_MINOR + "." + Version.VERSION_REVISION;
@@ -23,13 +32,62 @@ private static void checkLwjglRuntimeVersion() {
             return;
         }
 
+
+        String launcher = getLauncherBrand();
+        String codeSource = getLwjglCodeSource();
+        String codeSourceFilename = null;
+        if (codeSource != null) {
+            String[] components = codeSource.split("/");
+            codeSourceFilename = components[components.length-1];
+        }
+
+        if (codeSource != null) {
+            LOGGER.info("Problematic LWJGL version source: {}", codeSource);
+        }
+
+        boolean isCustomLauncher = !launcher.equals("minecraft-launcher") && !launcher.equals("unknown");
+        boolean isLikelyCausedByLauncher = false;
+        String isLikelyCausedByMod = null;
+
+        if (isCustomLauncher) {
+            if (codeSourceFilename != null && (codeSourceFilename.startsWith("lwjgl-") || codeSource.contains("/lwjgl/"))) {
+                isLikelyCausedByLauncher = true;
+            }
+        }
+        if (!isLikelyCausedByLauncher) {
+            if (codeSource != null && codeSource.endsWith("/mods/"+codeSourceFilename)) {
+                isLikelyCausedByMod = codeSourceFilename;
+            }
+        }
+
         String advice;
+        if (isLikelyCausedByMod != null) {
+            advice = """
+                    This issue seems to be caused by ###MOD###.
 
-        if (isUsingPrismLauncher()) {
+                    Removing ###MOD### from your mods folder may fix this issue."""
+                    .replace("###MOD###", isLikelyCausedByMod);
+        } else if (launcher.equalsIgnoreCase("prismlauncher")) {
             advice = """
                     It appears you are using Prism Launcher to start the game. You can \
                     likely fix this problem by opening your instance settings and navigating to the Version \
                     section in the sidebar.""";
+        } else if (isLikelyCausedByLauncher) {
+            advice = """
+                    You seem to be using ###LAUNCHER###. This issue is likely caused by ###LAUNCHER###.
+
+                    You must change the LWJGL version in your launcher to continue. \
+                    This is usually controlled by the settings for a profile or instance in your launcher.
+
+                    If you need assistance fixing the LWJGL version, you should contact ###LAUNCHER###, not Sodium."""
+                    .replace("###LAUNCHER###", launcher);
+        } else if (isCustomLauncher) {
+            advice = """
+                    You seem to be using ###LAUNCHER###.
+
+                    You must change the LWJGL version in your launcher to continue. \
+                    This is usually controlled by the settings for a profile or instance in your launcher."""
+                    .replace("###LAUNCHER###", launcher);
         } else {
             advice = """
                     You must change the LWJGL version in your launcher to continue. \
@@ -39,10 +97,10 @@ private static void checkLwjglRuntimeVersion() {
         String message = """
                         The game failed to start because the currently active LWJGL version is not \
                         compatible.
-                        
+
                         Installed version: ###CURRENT_VERSION###
                         Required version: ###REQUIRED_VERSION###
-                        
+
                         ###ADVICE_STRING###"""
                 .replace("###CURRENT_VERSION###", Version.getVersion())
                 .replace("###REQUIRED_VERSION###", REQUIRED_LWJGL_VERSION)
@@ -52,17 +110,54 @@ private static void checkLwjglRuntimeVersion() {
                 "https://link.caffeinemc.net/help/sodium/runtime-issue/lwjgl3/gh-2561");
     }
 
+    private static String getLwjglCodeSource() {
+        try {
+            ProtectionDomain domain = Version.class.getProtectionDomain();
+            if (domain != null) {
+                CodeSource source = domain.getCodeSource();
+                if (source != null) {
+                    URL location = source.getLocation();
+                    if (location != null) {
+                        String path = location.getPath();
+                        if (path != null) {
+                            path = path.replace('\\', '/');
+                            path = path.split("!")[0];
+                            return path;
+                        }
+                    }
+                }
+            }
+        } catch (Throwable t) {
+            LOGGER.error("Error while checking code source of LWJGL", t);
+        }
+        return null;
+    }
+
     private static boolean isUsingKnownCompatibleLwjglVersion() {
         return Version.getVersion()
                 .startsWith(REQUIRED_LWJGL_VERSION);
     }
 
-    private static boolean isUsingPrismLauncher() {
-        return getLauncherBrand()
-                .equalsIgnoreCase("PrismLauncher");
+    private static String getLauncherBrand() {
+        String brand = System.getProperty("minecraft.launcher.brand", "unknown");
+        if (brand.equals("unknown")) {
+            // Lunar Client uses a custom set of launch arguments
+            // which don't include minecraft.launcher.brand
+            if (isClassLoaded("com.moonsworth.lunar.genesis.Genesis")) {
+                return "Lunar Client";
+            } else if (System.getProperty("lunar.webosr.url") != null) {
+                return "Lunar Client";
+            }
+        }
+        return brand;
     }
 
-    private static String getLauncherBrand() {
-        return System.getProperty("minecraft.launcher.brand", "unknown");
+    private static boolean isClassLoaded(String className) {
+        try {
+            Class.forName(className);
+            return true;
+        } catch (ClassNotFoundException e) {
+            return false;
+        }
     }
 }